Skip to content

Commit

Permalink
Fix macOS ARM64 stack overflow detection (dotnet#66599)
Browse files Browse the repository at this point in the history
We were incorrectly using exception_data_type_t instead of mach_exception_data_type_t
in the PAL due to a missing change when we have added support for ARM64 macOS.

The wrong type was 32 bit and it caused the address of a hardware exception to have
the upper 32 bits cut off. That prevented us from detecting stack overflow correctly.
  • Loading branch information
janvorli authored and radekdoulik committed Mar 30, 2022
1 parent 645fbc2 commit 89542e5
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/coreclr/pal/src/exception/machmessage.h
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ using namespace CorUnix;

#if HAVE_MACH_EXCEPTIONS

#if defined(HOST_AMD64)
#if defined(HOST_64BIT)
#define MACH_EH_TYPE(x) mach_##x
#else
#define MACH_EH_TYPE(x) x
Expand Down

0 comments on commit 89542e5

Please sign in to comment.