Add formatter helper functions and refactor definitions #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohkale
changed the title
|
Would it be possible to split the file renaming and the adding/refactoring into two separate pull requests, so that in future it's easy to look back and see what changed? |
Yeah, I was planning to rebase-merge so the commits are clearly separated 😃. I'll fork the first 2 into a separate PR since this ones becoming a lot larger than I expected 🙃. |
|
Closing. I'll split this up into separate smaller PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLOSES #85.
Note: Tests are failing because I've added a lot of new formatters but no tests for them :/.