Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try again to preserve undo history #17

Closed
wants to merge 1 commit into from

Conversation

leungbk
Copy link
Contributor

@leungbk leungbk commented Jun 15, 2020

Closes #15.

@leungbk leungbk force-pushed the undo-hist branch 2 times, most recently from 7cd3be2 to 5daec5e Compare June 15, 2020 15:20
@leungbk
Copy link
Contributor Author

leungbk commented Jun 15, 2020

It seems that undo-amalgamate-change-group is not available prior to Emacs 26. Should we just paste in the source? Or should we simply drop support for 25?

@leungbk leungbk closed this Jun 16, 2020
@raxod502
Copy link
Member

Emacs 25 is still used enough that I think I'd prefer to continue supporting it. In particular it's shipped with the second-to-latest Ubuntu LTS which most people are probably still on who run Ubuntu LTS.

Pasting in the definition is fine, here is an example of how to do that.

@leungbk
Copy link
Contributor Author

leungbk commented Jun 28, 2020

I closed the PR since it didn't seem to do anything to alleviate the problem of large entries in buffer-undo-list.

Tha markers generated within apheleia--apply-rcs-patch seem to be accounting for much of the size of each entry within buffer-undo-list. But from a glance at the code, the markers look pretty important, so I'm not sure how the space usage of this function can be cut down.

@raxod502
Copy link
Member

Oh, huh. I didn't realize markers got recorded in the undo history. I guess that makes sense though. Do we clean them up properly? I don't see anything for that in the code. Perhaps they are accumulating over time and the undo history is getting exponentially bigger because of all the markers getting moved around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Seems to wreck undo history
2 participants