Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

strip trailing CR #54

Merged
merged 2 commits into from
Oct 31, 2021
Merged

strip trailing CR #54

merged 2 commits into from
Oct 31, 2021

Conversation

asif-mahmud
Copy link
Contributor

adding --strip-trailing-cr to diff command fixes the issue #53

raxod502
raxod502 reviewed Oct 24, 2021
View reviewed changes
Copy link
Member

@raxod502 raxod502 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this on Ubuntu 21.04 and macOS 10.14.6 and --strip-trailing-cr appeared to be supported on both, so this seems safe to me. Mind updating the changelog?

@asif-mahmud
Copy link
Contributor Author

Hi, i have updated the changelog. not sure if its up to the specs though.

raxod502
raxod502 approved these changes Oct 31, 2021
View reviewed changes
Copy link
Member

@raxod502 raxod502 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ LGTM, thanks.

@raxod502 raxod502 merged commit 0c88ad9 into radian-software:master Oct 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raxod502 raxod502 raxod502 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asif-mahmud @raxod502 @Shimon-Technext