-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make minibuffer keymap available #62
Comments
It's because I thought it was an elegant idea at the time. Since then, it has been pointed out by everyone else on the Internet that it's not a good idea -- but nobody has yet gone back and changed the variable to a regular keymap :) |
I can send a PR if you agree that this is a good change. Do you think we can keep compat with the old variable? Or should we just delete it and replace it with a new map variable. |
Yes, definitely a good change, feel free. I'd like to keep backwards compatibility, but it's a little tricky in this case. Here's one way that I think could work nicely. When we are applying the keymap, we can check the value of |
Awesome, thanks for the PR, but I have a few questions:
|
Yes, backwards compatibility.
Looks like only one of the two keymaps was fixed in the linked PR, I didn't notice that before.
It's been updated in the linked PR. |
Thanks to @dawranliou this has now been fixed in #97. |
Hi,
I like using which-key to inspect keymaps. Is there a reason why the keymap itself has to be created on the fly? Can it be the global variable we get to customize instead of the list of bindings.
The text was updated successfully, but these errors were encountered: