Add ctrlf-mode-map

[rgrinberg]

Attempt to fix #62.

I'm not sure I fully understand your
comment(my
elisp is weak), but I figure it's easier to continue the discussion
with some concrete code.

---

[raxod502]

Yeah, this is exactly the check that I was suggesting. Thanks for taking it on! Just a few small changes:

• I think we now need to rename the reference to ctrlf--keymap below to ctrlf-mode-map.
• I think we probably want to keep the (setcdr ctrlf-mode-map nil) call (only in the case where your when clause passes, of course). It makes it so if you remove a binding from ctrlf-mode-map, it actually gets deactivated.
• We should update the docstring of ctrlf-mode-bindings to say it's deprecated, and probably mark the variable as such (I think this is done with make-obsolete-variable, or perhaps defcustom has an option specially for this).
• There should be an accompanying README update, and changelog entry.

[raxod502]

Oh yes, also the CI is currently failing (due to the reference to ctrlf--keymap).

[rgrinberg]

Thanks for the review. I think I addressed all your comments.

[rgrinberg]

I can make an analogous change for ctrlf-minibuffer-bindings. Should it be called ctrlf-minibuffer-map?

[raxod502]

Thanks, that looks good to me. Yes, doing the same for ctrlf-minibuffer-bindings and naming it ctrlf-minibuffer-map sounds perfect.

[rgrinberg]

@raxod502 sorry for the delay. should be ready now

[raxod502]

Would you mind fixing the CI failures? This also may need a bit of additional consideration with the change ddfbc35 from February.

[raxod502]

This thread is being closed automatically by Tidier because it is labeled with "waiting on response" and has not seen any activity for 90 days. But don't worry—if you have any information that might advance the discussion, leave a comment and I will be happy to reopen the thread :)