Can't patch functions with literal cons cells in their definitions

[caadar]

I can't patch org-auto-repeat-maybe from org.el.

Just change `defun' to `el-patch-defun' end evaluate the form.
Messages says: cl-mapcar: Wrong type argument: listp, hour

[raxod502]

Fun fun fun. I can reproduce it. Let me see what's the matter.

[raxod502]

Oh, it's because el-patch--resolve only recurses correctly into list forms, and not other things like cons cells. That should be fairly straightforward to fix.

[raxod502]

This turns out to be more difficult fun than expected. Because fully handling improper lists requires making

(a b (el-patch-add c . d))

resolve to

(a b c . d)

which is nontrivial (and not even necessarily something that makes sense).

[caadar]

The same with (el-patch-defvar xml-entity-alist ...).

[raxod502]

The same with (el-patch-defvar counsel-mode-map ...), unfortunately.

[raxod502]

Hey, it's fixed (finally)! Give it a try :)