Update handling of minibuffer message overlays #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clemera
changed the title
clemera
changed the title
|
Turns out for They already do the right thing with: (put-text-property 0 1 'cursor 1 message)There is no user visible change and the cursor jumping for |
clemera
changed the title
This was referenced Aug 7, 2020
|
Well, that's certainly good news! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cursor would jump forth and back when displaying the message. Overriding
make-overlayisn't necessary any more because the content is only defined by the input now but instead we need to make sure the cursor stays at the front of the overlay by overridingput-text-propertywhen callingminibuffer-message. I won't merge this before also adjustingselectrum--fix-set-minibuffer-messagewhich I will do after upgrading to Emacs 27 where I can test it.