straight--build-compile: fix compile process load-path #1132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
progfolio
force-pushed
the
fix/compile
branch
from
1f1eae8 to
3468d18
Compare
Compute child byte-compilation process load-path via straight-dependencies. This should include the necessary transitive dependencies as well as direct dependencies.
|
Hi, I can also confirm this works! I've got a problem where Using the patch here helps and everything seems to be working correctly now 🙂 |
4 tasks
hlissner
added a commit
to doomemacs/doomemacs
that referenced
this pull request
Jul 26, 2024
FrauH0lle
added a commit
to FrauH0lle/emacs.d
that referenced
this pull request
Jul 31, 2024
real-or-random
added a commit
to real-or-random/doomemacs
that referenced
this pull request
Jan 17, 2025
This reverts a workaround for straight that is no longer necessary because it has been applied upstream. For some reason I don't understand, this reproducibly fixes a reoccurrence of the original problem for me: Before this commit, some files of the citar package were not byte-compiled. After this commit, the problem is gone. This effectively reverts 54a084f, though it's not a reverting commit in strict sense because the code has been moved to a different file. Revert: 54a084f Ref: doomemacs#7707 Ref: radian-software/straight.el#1132
real-or-random
added a commit
to real-or-random/doomemacs
that referenced
this pull request
Jan 17, 2025
This reverts a workaround for straight that is no longer necessary because it has been applied upstream. For some reason I don't understand, this reproducibly fixes a reoccurrence of the original problem for me: Before this commit, some files of the citar package were not byte-compiled. After this commit, the problem is gone. This effectively reverts 54a084f, though it's not a reverting commit in strict sense because the code has been moved to a different file. Revert: 54a084f Ref: doomemacs#7707 Ref: radian-software/straight.el#1132 Ref: https://discourse.doomemacs.org/t/is-it-expected-that-doom-sync-does-not-byte-compile-native-compile-some-files/4946
7 tasks
real-or-random
added a commit
to real-or-random/doomemacs
that referenced
this pull request
Jan 17, 2025
This reverts a workaround for straight that is no longer necessary because it has been applied upstream and we've bumped the package since. For some reason I don't understand, this reproducibly fixes a reoccurrence of the original problem for me: Before this commit, some files of the citar package were not byte-compiled. After this commit, the problem is gone. This effectively reverts 54a084f, though it's not a reverting commit in strict sense because the code has been moved to a different file. Revert: 54a084f Ref: d80c5e5 Ref: doomemacs#7707 Ref: radian-software/straight.el#1132 Ref: https://discourse.doomemacs.org/t/is-it-expected-that-doom-sync-does-not-byte-compile-native-compile-some-files/4946
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compute child byte-compilation process load-path via straight-dependencies.
This should include the necessary transitive dependencies as well as
direct dependencies.
See: #1131