Don't call pre-build functions unless building #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't call the things on the `straight-use-package-pre-build-functions` hook unless we're actually going to do a build. I use the pre-build-functions hook to call `autoconf/configure/make` for the vm package before the build happens and w/out this change it was happening on every startup. With this change it only happens when necessary.
|
Looks great, thanks for the help. |
|
You're welcome. Thanks for the mentoring! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't call the things on the
straight-use-package-pre-build-functionshook unless we're actually going to do a build.I use the pre-build-functions hook to call
autoconf/configure/makefor the vm package before the build happens and w/out this change it was happening on every startup. With this change it only happens when necessary.Closes #386