Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More CI checks and clean-up #10

Merged
merged 3 commits into from
Apr 2, 2020
Merged

More CI checks and clean-up #10

merged 3 commits into from
Apr 2, 2020

Conversation

m-mohr
Copy link
Collaborator

@m-mohr m-mohr commented Mar 31, 2020

Related Issue(s): #8

Proposed Changes:

  • Validation for OpenAPI files (npm run check-openapi)
  • Linting for Markdown files (npm run check-markdown)
  • Update CI to do all checks automatically (npm run check)
  • Fix issues found in OpenAPI files (see Fixes and CI for OpenAPI files  #11)
  • Fix issues found in Markdown files

This doesn't enable CI check for the OpenAPI files yet as it will take us a bit more work to get our OpenAPI files valid (at the moment - includes released 0.9.0 version - they are invalid). Will make a separate PR for API changes.

PR Checklist:

  • This PR has no breaking changes.
  • I have added my changes to the CHANGELOG or a CHANGELOG entry is not required.
  • API only: I have run npm run generate-all to update the generated OpenAPI files.

@m-mohr m-mohr self-assigned this Mar 31, 2020
@m-mohr m-mohr marked this pull request as ready for review March 31, 2020 20:50
@m-mohr m-mohr changed the title More CI checks and clean-up [WIP] More CI checks and clean-up Mar 31, 2020
@m-mohr m-mohr mentioned this pull request Mar 31, 2020
@m-mohr m-mohr changed the title [WIP] More CI checks and clean-up More CI checks and clean-up Apr 1, 2020
@m-mohr m-mohr mentioned this pull request Apr 1, 2020
6 tasks
@m-mohr m-mohr force-pushed the ci-checks branch 2 times, most recently from 71ed3af to ad7fd8a Compare April 1, 2020 14:39
Copy link
Collaborator

@cholmes cholmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for all this work.

@m-mohr m-mohr merged commit 43799ad into master Apr 2, 2020
@m-mohr m-mohr deleted the ci-checks branch April 2, 2020 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants