Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shall and endpoint table #200

Merged
merged 2 commits into from
Sep 8, 2021

Conversation

philvarner
Copy link
Collaborator

…implemented for each conformance class

Related Issue(s): #195

Proposed Changes:

  1. change wording of required endpoints for each conformance class from "should" to "shall".

Technically this is a breaking change, but it was understood before that these were required, we just used the wrong word in the spec.

PR Checklist:

  • This PR is made against the dev branch (all proposed changes except releases should be against dev, not master).
  • ??? This PR has no breaking changes.
  • This PR does not make any changes to the core spec in the stac-spec directory (these are included as a subtree and should be updated directly in radiantearth/stac-spec)
  • I have added my changes to the CHANGELOG or a CHANGELOG entry is not required.

Copy link
Collaborator

@cholmes cholmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Do we define somewhere our use of should / shall? Like refer to a document or explain it somewhere?

@philvarner
Copy link
Collaborator Author

We don't have it explicitly stated anywhere, but I think it's widely known enough that we don't need to.

@philvarner philvarner merged commit b0908f8 into radiantearth:dev Sep 8, 2021
@philvarner philvarner deleted the shall-and-endpoint-table branch September 8, 2021 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants