Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix headers so VSCode header won't remove Summary section #384

Merged
merged 1 commit into from
Jan 30, 2023
Merged

fix headers so VSCode header won't remove Summary section #384

merged 1 commit into from
Jan 30, 2023

Conversation

philvarner
Copy link
Collaborator

Related Issue(s):

  • n/a

Proposed Changes:

  1. Add headers to readmes so VS Code markdown-all-in-one won't remove Summary content

PR Checklist:

  • This PR has no breaking changes.
  • This PR does not make any changes to the core spec in the stac-spec directory (these are included as a subtree and should be updated directly in radiantearth/stac-spec)
  • I have added my changes to the CHANGELOG or a CHANGELOG entry is not required.

@philvarner philvarner requested a review from m-mohr January 30, 2023 16:37
m-mohr
m-mohr approved these changes Jan 30, 2023
View reviewed changes
Copy link
Collaborator

@m-mohr m-mohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one question regarding the removal of a sentence.

@philvarner philvarner merged commit 001e7cf into main Jan 30, 2023
@m-mohr m-mohr deleted the pv/fix-headers-and-toc branch January 30, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-mohr m-mohr m-mohr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philvarner @m-mohr