Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify the self link is absolute #1241

Closed
m-mohr opened this issue Jul 19, 2023 · 4 comments · Fixed by #1281
Closed

Verify the self link is absolute #1241

m-mohr opened this issue Jul 19, 2023 · 4 comments · Fixed by #1281

Comments

@m-mohr
Copy link
Collaborator

m-mohr commented Jul 19, 2023

Add a rule to the JSON schema that verifies that the self links are absolute.

@m-mohr m-mohr added this to the 1.1 milestone Jul 19, 2023
@kbgg
Copy link
Member

kbgg commented Jul 24, 2023

Requiring all self links be absolute creates difficulties for portable catalogs. The recommendation here is that for portable catalogs there only needs to be a single absolute self link at the root of the catalog. I'd recommend removing the requirement that all self links be absolute and instead require an absolute link exists at the root of the catalog

@m-mohr
Copy link
Collaborator Author

m-mohr commented Jul 24, 2023

If you can't provide absolute links, don't provide a self link at all. I don't know what a relative self link really helps with?

@kbgg
Copy link
Member

kbgg commented Jul 24, 2023

Fair enough, I was under the impression that self links are required but after another quick read through the spec that doesn't seem to be the case

@m-mohr
Copy link
Collaborator Author

m-mohr commented Jul 24, 2023

Indeed, they are optional, but if you provide them they must be absolute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants