Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validation for absolute self link in item schema #1281

Merged
merged 3 commits into from
Jul 8, 2024
Merged

Add validation for absolute self link in item schema #1281

merged 3 commits into from
Jul 8, 2024

Conversation

emmanuelmathot
Copy link
Collaborator

@emmanuelmathot emmanuelmathot commented May 14, 2024 •
edited
Loading

Related Issue(s): #1241

Proposed Changes:

  1. Add validation for absolute self link in item schema

PR Checklist:

  • This PR is made against the dev branch (all proposed changes except releases should be against dev, not master).
  • This PR has no breaking changes.
  • I have added my changes to the CHANGELOG
    or a CHANGELOG entry is not required.
  • This PR affects the STAC API spec,
    and I have opened issue/PR #XXX to track the change.

@emmanuelmathot emmanuelmathot added this to the 1.1 milestone May 14, 2024
@m-mohr m-mohr linked an issue May 14, 2024 that may be closed by this pull request
Verify the self link is absolute #1241
Closed
@gadomski gadomski mentioned this pull request Jun 3, 2024
Open
@emmanuelmathot
Copy link
Collaborator Author

@gadomski ready for review

@emmanuelmathot emmanuelmathot self-assigned this Jul 4, 2024
@m-mohr m-mohr merged commit 3a61f75 into dev Jul 8, 2024
2 checks passed
@m-mohr m-mohr deleted the absself branch July 8, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-mohr m-mohr m-mohr approved these changes

@gadomski gadomski gadomski approved these changes

@cholmes cholmes Awaiting requested review from cholmes

@matthewhanson matthewhanson Awaiting requested review from matthewhanson

@lossyrob lossyrob Awaiting requested review from lossyrob

@jbants jbants Awaiting requested review from jbants

Assignees

@emmanuelmathot emmanuelmathot

Labels
best practice json schema
Projects
None yet
Milestone
1.1.0-beta.1
Development

Successfully merging this pull request may close these issues.

Verify the self link is absolute
3 participants
@emmanuelmathot @gadomski @m-mohr