Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change 'links' back to a list from a dictionary. #197

Closed
cholmes opened this issue Aug 24, 2018 · 1 comment
Closed

Change 'links' back to a list from a dictionary. #197

cholmes opened this issue Aug 24, 2018 · 1 comment
Labels
major This will take substantial work / thinking to do. prio: must-have required for release associated with
Milestone
0.6.0-RC1

Comments

@cholmes
Copy link
Contributor

cholmes commented Aug 24, 2018

There was lots of discussion at the sprint on lists vs dictionary. At sprint 2 we changed links to a dict in #114 But in #127 we realized we had gone a bit too far. At the sprint we discussed going back to lists for everything, see #151 The conclusion from everyone is that we should definitely shift links back to lists.

I believe 'assets' is still up for debate, so will just limit this issue to the links. But we may want to update assets too.
@cholmes cholmes added major This will take substantial work / thinking to do. prio: must-have required for release associated with labels Aug 24, 2018
@cholmes cholmes added this to the 0.6.0 milestone Aug 24, 2018
@cholmes cholmes mentioned this issue Aug 24, 2018
Closed
This was referenced Aug 24, 2018
Closed
Merged
m-mohr added a commit that referenced this issue Aug 28, 2018
@m-mohr
Change 'links' back to a list from a dictionary in items. #197
1d2d473
@m-mohr m-mohr mentioned this issue Aug 28, 2018
Merged
@m-mohr
Copy link
Collaborator

m-mohr commented Aug 28, 2018 •
edited
Loading

Implemented with PR #219.

m-mohr added a commit that referenced this issue Aug 29, 2018
@m-mohr
Change 'links' back to a list from a dictionary in items. #197
e969448
cholmes added a commit that referenced this issue Sep 3, 2018
@cholmes
Merge pull request #219 from radiantearth/links-to-arrays2
165163c 
Change 'links' back to a list from a dictionary (#197)
@m-mohr m-mohr closed this as completed Sep 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
major This will take substantial work / thinking to do. prio: must-have required for release associated with
Projects
None yet
Milestone
0.6.0-RC1
Development

No branches or pull requests
2 participants
@cholmes @m-mohr