Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OpenAPI definition to catalog / dataset definition #257

Closed
cholmes opened this issue Oct 1, 2018 · 4 comments
Closed

Update OpenAPI definition to catalog / dataset definition #257

cholmes opened this issue Oct 1, 2018 · 4 comments
Assignees
Labels
prio: must-have required for release associated with
Milestone

Comments

@cholmes
Copy link
Contributor

cholmes commented Oct 1, 2018

The OpenAPI definition still has the old Catalog definition, with keywords, provider, etc. See https://github.com/radiantearth/stac-spec/blob/dev/api-spec/definitions/STAC-standalone.yaml#L328 (though I'm not sure if that's where the spec is defined or if that file is built from others).

It should be updated to be in line with what we have in dev for catalog. Could have the return example be a dataset, to show a fuller return.

Should also try to communicate a bit more in that OpenAPI snippet, like that /stac can be a catalog that links to other catalogs, or a dataset definition, or even alternate 'views' in to the data.

@cholmes cholmes added the prio: must-have required for release associated with label Oct 1, 2018
@cholmes cholmes added this to the 0.6.0-RC1 milestone Oct 1, 2018
@cholmes cholmes assigned m-mohr and ghost Oct 1, 2018
@m-mohr
Copy link
Collaborator

m-mohr commented Oct 5, 2018

Let's make this once we have #262 fully in. It's a bit of work to be done and I'd like to have that PR finalized first.

@cholmes
Copy link
Contributor Author

cholmes commented Oct 6, 2018

Sure, no problem - I just wanted to be sure the issue was in so it's sure to get done.

@m-mohr
Copy link
Collaborator

m-mohr commented Oct 8, 2018

I'm still waiting for #268 and #269 to get discussed and merged as these also require changes in the API.

@m-mohr
Copy link
Collaborator

m-mohr commented Oct 9, 2018

Should be updated with PR #271 , but needs to be reviewed carefully due to the huge amount of changes.

m-mohr added a commit that referenced this issue Oct 10, 2018
#257: Update OpenAPI definition to catalog / dataset definition
@m-mohr m-mohr closed this as completed Oct 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prio: must-have required for release associated with
Projects
None yet
Development

No branches or pull requests

2 participants