Collection: Open intervals for temporal extents #1127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-mohr
requested review from
lossyrob,
matthewhanson,
philvarner and
emmanuelmathot
philvarner
reviewed
May 10, 2021
| @@ -202,12 +202,17 @@ Clients only interested in the overall extent will only need to access the first | |||
| It is recommended to only use multiple temporal extents if a union of them would then include a large | |||
| uncovered time span (e.g. only having data for the years 2000, 2010 and 2020). | |||
|
|
|||
| Each inner array consists of exactly two dates and times, each in UTC. | |||
| Each date and time MUST be formatted according to [RFC 3339, section 5.6](https://tools.ietf.org/html/rfc3339#section-5.6). | |||
| Each inner array consists of exactly two elements, either a timestamp or `null`. | |||
There was a problem hiding this comment.
I think we use "datetime" most places in the text instead of "timestamp" -- I always think of unix epoch milliseconds when I see timestamp.
There was a problem hiding this comment.
With the explanation below it should be clear, right?
Timestamps consist of a date and time in UTC and MUST be formatted according to RFC 3339...
It's a bit strange to write "Datetimes consist of a date and time" below...
cholmes
approved these changes
May 11, 2021
philvarner
reviewed
May 11, 2021
philvarner
reviewed
May 11, 2021
philvarner
reviewed
May 11, 2021
Update years in example.
jbants
approved these changes
May 11, 2021
collection-spec/collection-spec.md
Outdated
| Open date ranges are supported by setting either the start or the end time to `null`. | ||
| Example for data from the beginning of 2019 until now: `[["2009-01-01T00:00:00Z", null]]`. | ||
| Open date ranges are supported by setting the start and/or the end time to `null`. | ||
| Example for data from the beginning of 2019 until now: `[["2009-01-01T00:00:00Z", null]]`. |
There was a problem hiding this comment.
should be:
Example for data from the beginning of 2019 until now: [["2019-01-01T00:00:00Z", null]]``
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s): #1125
Proposed Changes:
PR Checklist:
or a CHANGELOG entry is not required.
and I have opened issue/PR #XXX to track the change.