Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace collections extension with commons extension #275

Merged
merged 9 commits into from
Oct 11, 2018
Merged

Conversation

matthewhanson
Copy link
Collaborator

Changes the Collections extension with the Commons extension.

This allows putting properties that belong to an Item into it's Collection and have it apply to all member Items.

@m-mohr
Copy link
Collaborator

m-mohr commented Oct 9, 2018

Not reviewed yet, but I'd like to have all extensions in folders. Therefore I'd suggest moving the file in a commons folder. Same should be done with the EO extension, but that can be a separate PR of course.

extensions/commons/README.md Outdated Show resolved Hide resolved
@matthewhanson
Copy link
Collaborator Author

@m-mohr I did move it into a 'commons' folder.

@matthewhanson matthewhanson added the prio: must-have required for release associated with label Oct 10, 2018
Copy link
Collaborator

@m-mohr m-mohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for moving the extension to a separate folder. I went through the document and fixed some issues regarding the formatting and also fixed JSON validation errors. Other than that it is great work. I'm generally fine with everything now and would approve, but I am missing two things.

  1. A full example in the examples folder.
  2. I'd also like to add in a paragraph that if you are only using Collections without linking to Items, that it is fine to use the extension as well. At least in openEO, I'll encourage the implementors to just use the Commons extension and add all their fields from the Common Metadata Model to describe their collections without actually linking to their items as we usually have big data cubes that are not available for download.

@matthewhanson
Copy link
Collaborator Author

@m-mohr examples added and README updated

@matthewhanson matthewhanson requested review from hgs-msmith and a user October 10, 2018 17:47
Copy link
Contributor

@hgs-msmith hgs-msmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do think this is a better name, and likely to reduce confusion.

@m-mohr m-mohr merged commit 20e36f1 into dev Oct 11, 2018
@m-mohr m-mohr deleted the commons_extension branch October 11, 2018 08:19
m-mohr added a commit that referenced this pull request Oct 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prio: must-have required for release associated with
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants