-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace collections extension with commons extension #275
Conversation
Not reviewed yet, but I'd like to have all extensions in folders. Therefore I'd suggest moving the file in a commons folder. Same should be done with the EO extension, but that can be a separate PR of course. |
@m-mohr I did move it into a 'commons' folder. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for moving the extension to a separate folder. I went through the document and fixed some issues regarding the formatting and also fixed JSON validation errors. Other than that it is great work. I'm generally fine with everything now and would approve, but I am missing two things.
- A full example in the examples folder.
- I'd also like to add in a paragraph that if you are only using Collections without linking to Items, that it is fine to use the extension as well. At least in openEO, I'll encourage the implementors to just use the Commons extension and add all their fields from the Common Metadata Model to describe their collections without actually linking to their items as we usually have big data cubes that are not available for download.
@m-mohr examples added and README updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do think this is a better name, and likely to reduce confusion.
Changes the Collections extension with the Commons extension.
This allows putting properties that belong to an
Item
into it'sCollection
and have it apply to all memberItem
s.