Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document asset rel #316

Closed
wants to merge 1 commit into from
Closed

Document asset rel #316

wants to merge 1 commit into from

Conversation

mojodna
Copy link
Collaborator

@mojodna mojodna commented Oct 23, 2018

rel establishes the relationship between the current document and the linked asset.

Common relationships include: "thumbnail" (usually singular), "visual" (1+), "analytic" (1+), "qa" (1+).

This currently complements the asset key, particularly in scenarios where it would need to be parsed to determine its relationship (e.g. visual-1, visual-SWIR, etc.)

Refs #308
Refs #309

PR Checklist:

  • This PR has no breaking changes.
  • I have added my changes to the CHANGELOG or a CHANGELOG entry is not required.
  • API only: I have run npm run generate-all. to update the generated OpenAPI files.

@mojodna mojodna added this to the 0.7.0 milestone Oct 23, 2018
@matthewhanson
Copy link
Collaborator

I don't think this is sufficient to do what we need, because as you pointed out in #308, a visual product could be spread out over multiple files and this wouldn't be able to depict that because there's no order specified anywhere.

I think these different use cases are better off defined in the Asset definition.

@cholmes cholmes modified the milestones: 0.7.0, 0.8.0 Apr 20, 2019
@m-mohr m-mohr added assets and removed proposal labels Jul 22, 2019
@ghost
Copy link

ghost commented Aug 1, 2019

I'm not sure if there is enough of a difference between type and rel for me. Both of them use thumbnail as a primary example.

@m-mohr
Copy link
Collaborator

m-mohr commented Aug 5, 2019

The value for the field type must be a media type according to the spec. thumbnail as type would be invalid and should be replaced with image/.... Are you referring to another 'type', @hgs-truthe01 ?

@ghost
Copy link

ghost commented Aug 5, 2019

@m-mohr

The asset spec says: Media type of the asset (see chapter on Media Types below).
The chapter below is a table with 1 row where type is "thumbnail".

I know we discussed mime types, but it doesn't actually say that and the one type that is listed shows thumbnail. So I think we need to de-conflict the definitions.

@m-mohr
Copy link
Collaborator

m-mohr commented Aug 5, 2019

@hgs-truthe01 You are looking at the Asset Type chapter, but further down there's a Media Type chapter. The Asset Types are the property keys of the assets and the Media Types are for the field type. So I think you looked at the wrong table/chapter.

Nevertheless, I agree with you that a rel somewhat duplicates the property key for the asset.

@ghost
Copy link

ghost commented Aug 5, 2019

@m-mohr I see what you are saying, but that is actually even more confusing then. Asset Type needs to be renamed to something like Asset Name. We have 3 tables in a row that are all "types". If it said "Asset Key Name", "Asset Relation", and "Media Type" it might make more sense.

@m-mohr m-mohr modified the milestones: 0.8.0, 0.9.0 Aug 19, 2019
@matthewhanson
Copy link
Collaborator

Closed in favor of #637

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants