-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document asset rel #316
Document asset rel #316
Conversation
I don't think this is sufficient to do what we need, because as you pointed out in #308, a visual product could be spread out over multiple files and this wouldn't be able to depict that because there's no order specified anywhere. I think these different use cases are better off defined in the Asset definition. |
I'm not sure if there is enough of a difference between type and rel for me. Both of them use thumbnail as a primary example. |
The value for the field |
The asset spec says: Media type of the asset (see chapter on Media Types below). I know we discussed mime types, but it doesn't actually say that and the one type that is listed shows thumbnail. So I think we need to de-conflict the definitions. |
@hgs-truthe01 You are looking at the Asset Type chapter, but further down there's a Media Type chapter. The Asset Types are the property keys of the assets and the Media Types are for the field Nevertheless, I agree with you that a |
@m-mohr I see what you are saying, but that is actually even more confusing then. Asset Type needs to be renamed to something like Asset Name. We have 3 tables in a row that are all "types". If it said "Asset Key Name", "Asset Relation", and "Media Type" it might make more sense. |
Closed in favor of #637 |
rel
establishes the relationship between the current document and the linked asset.Common relationships include: "thumbnail" (usually singular), "visual" (1+), "analytic" (1+), "qa" (1+).
This currently complements the asset key, particularly in scenarios where it would need to be parsed to determine its relationship (e.g.
visual-1
,visual-SWIR
, etc.)Refs #308
Refs #309
PR Checklist:
npm run generate-all
. to update the generated OpenAPI files.