Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Null geometry clarification #854

Merged
merged 13 commits into from
Jul 1, 2020
Merged

Null geometry clarification #854

merged 13 commits into from
Jul 1, 2020

Conversation

cholmes
Copy link
Contributor

@cholmes cholmes commented Jun 23, 2020

Related Issue(s): #843

Proposed Changes:

  1. Tweaked item spec to not require bbox if geometry is null
  2. Updated best practices to explain cases when this should be used.

PR Checklist:

  • This PR is made against the dev branch (all proposed changes except releases should be against dev, not master).
  • This PR has no breaking changes.
  • I have added my changes to the CHANGELOG or a CHANGELOG entry is not required.
  • This PR affects the STAC API spec, and I have opened issue/PR #XXX to track the change.

@cholmes
Copy link
Contributor Author

cholmes commented Jun 23, 2020

@m-mohr - could you update the schema to make the bbox not required if geometry is null? And a review would be great.

@m-mohr
Copy link
Collaborator

m-mohr commented Jun 23, 2020

Should we also add an example? And may it only be for checking that the JSON Schema works...

best-practices.md Outdated Show resolved Hide resolved
best-practices.md Outdated Show resolved Hide resolved
item-spec/item-spec.md Outdated Show resolved Hide resolved
Co-authored-by: Matthias Mohr <m.mohr@uni-muenster.de>
item-spec/item-spec.md Outdated Show resolved Hide resolved
@m-mohr m-mohr added this to the 1.0.0-beta.2 milestone Jun 23, 2020
@m-mohr m-mohr linked an issue Jun 23, 2020 that may be closed by this pull request
cholmes and others added 3 commits June 23, 2020 12:20
Co-authored-by: Matthias Mohr <m.mohr@uni-muenster.de>
@cholmes
Copy link
Contributor Author

cholmes commented Jun 23, 2020

As for an example, I'm of two minds. 1) be able to make sure the schema works is definitely a good thing. 2) don't really want to highlight this so much. And the plan is to slim down our examples more, so if one of just a handful of examples has a null then it would almost draw attention to it.

If you want to I'd say go for it, as I'm conflicted on it.

@m-mohr
Copy link
Collaborator

m-mohr commented Jun 23, 2020

Let's see whether someone provides a good example: #843 (comment)

@m-mohr m-mohr force-pushed the null-geometry-clarification branch from 9191b38 to 0369fb0 Compare June 24, 2020 08:16
@m-mohr
Copy link
Collaborator

m-mohr commented Jun 24, 2020

I added the JSON Schema changes.

@m-mohr m-mohr mentioned this pull request Jun 24, 2020
4 tasks
@m-mohr m-mohr removed their assignment Jun 24, 2020
@m-mohr m-mohr requested a review from matthewhanson June 24, 2020 09:06
@matthewhanson matthewhanson merged commit 14da94d into dev Jul 1, 2020
@matthewhanson matthewhanson deleted the null-geometry-clarification branch July 1, 2020 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty Geometries?
3 participants