Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow launcher command for flux startup #402

Merged
merged 13 commits into from
May 1, 2024
Merged

Conversation

andre-merzky
Copy link
Member

No description provided.

Copy link
Collaborator

@mtitov mtitov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanx!

Copy link

codecov bot commented Apr 29, 2024

Codecov Report

Attention: Patch coverage is 44.00000% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 62.02%. Comparing base (3a782df) to head (42a7eb1).

❗ Current head 42a7eb1 differs from pull request most recent head c43e7e5. Consider uploading reports for the commit c43e7e5 to get more accurate results

Files Patch % Lines
src/radical/utils/env.py 50.00% 8 Missing ⚠️
src/radical/utils/flux.py 25.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            devel     #402      +/-   ##
==========================================
- Coverage   62.26%   62.02%   -0.25%     
==========================================
  Files          61       61              
  Lines        6777     6783       +6     
==========================================
- Hits         4220     4207      -13     
- Misses       2557     2576      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andre-merzky andre-merzky merged commit dd54e29 into devel May 1, 2024
5 of 8 checks passed
@andre-merzky andre-merzky deleted the fix/flux_launcher branch May 1, 2024 19:51
@andre-merzky andre-merzky restored the fix/flux_launcher branch May 1, 2024 19:52
@mtitov mtitov added the external label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants