Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove an obsolete monkeypatch #415

Merged
merged 12 commits into from
Oct 1, 2024
Merged

remove an obsolete monkeypatch #415

merged 12 commits into from
Oct 1, 2024

Conversation

andre-merzky
Copy link
Member

No description provided.

Copy link

codecov bot commented Aug 26, 2024

Codecov Report

Attention: Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.

Project coverage is 61.84%. Comparing base (204ba74) to head (fef5bbe).
Report is 13 commits behind head on devel.

Files with missing lines Patch % Lines
src/radical/utils/atfork/__init__.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            devel     #415      +/-   ##
==========================================
- Coverage   62.17%   61.84%   -0.34%     
==========================================
  Files          62       62              
  Lines        6901     6903       +2     
==========================================
- Hits         4291     4269      -22     
- Misses       2610     2634      +24     
Flag Coverage Δ
61.84% <92.30%> (-0.34%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andre-merzky andre-merzky marked this pull request as draft August 28, 2024 21:44
@andre-merzky andre-merzky marked this pull request as ready for review September 2, 2024 10:22
@andre-merzky
Copy link
Member Author

I am not sure why the tests fail here - they seem to work alright alright. Any insight?

.github/workflows/ci.yml Outdated Show resolved Hide resolved
Copy link
Collaborator

@mtitov mtitov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andre-merzky andre-merzky merged commit 10e51d5 into devel Oct 1, 2024
10 checks passed
@andre-merzky andre-merzky deleted the fix/logging_patch branch October 1, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants