Skip to content

Commit

Permalink
Reenable System.Runtime.Serialization.Xml.Tests
Browse files Browse the repository at this point in the history
This was disabled due to dotnet#59926,
which was then tracked by dotnet#61061
.

The stack overflow is due to one specific test though, and the rest of
the tests can be enabled if we skip this one - `DCS_DeeplyLinkedData`.
  • Loading branch information
radical committed May 5, 2022
1 parent 393be55 commit 51acc0d
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -4256,6 +4256,7 @@ public static void DCS_TypeWithPrimitiveKnownTypes()
}

[ActiveIssue("https://github.com/dotnet/runtime/issues/1417", TestPlatforms.OSX)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/61061", TestPlatforms.Browser)]
[Fact]
public static void DCS_DeeplyLinkedData()
{
Expand Down
2 changes: 0 additions & 2 deletions src/libraries/tests.proj
Original file line number Diff line number Diff line change
Expand Up @@ -333,8 +333,6 @@

<!-- Aggressive Trimming related failures -->
<ItemGroup Condition="('$(TargetOS)' != 'Browser' and '$(RunAOTCompilation)' == 'true' and '$(MonoForceInterpreter)' != 'true') or ('$(TargetOS)' == 'Browser' and '$(BuildAOTTestsOnHelix)' == 'true' and '$(RunDisabledWasmTests)' != 'true')">
<!-- Issue: https://github.com/dotnet/runtime/issues/59926 -->
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Runtime.Serialization.Xml\tests\System.Runtime.Serialization.Xml.Tests.csproj" />
</ItemGroup>

<ItemGroup Condition="('$(TargetOS)' != 'Browser' and '$(RunAOTCompilation)' == 'true' and '$(MonoForceInterpreter)' != 'true') or ('$(TargetOS)' == 'Browser' and '$(BuildAOTTestsOnHelix)' == 'true' and '$(RunDisabledWasmTests)' != 'true') or ('$(TargetOS)' == 'iOS' and '$(BuildTestsOnHelix)' == 'true')">
Expand Down

0 comments on commit 51acc0d

Please sign in to comment.