Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: modded alg to stop recommending outfits with the same core items #128

Merged
merged 3 commits into from
Jan 8, 2025

Conversation

rak3rman
Copy link
Member

@rak3rman rak3rman commented Jan 8, 2025

Upgraded the algorithm to count the number of recently worn items, and use that data to further penalize other outfits up until the recency threshold.

@rak3rman rak3rman added backend Related to the hono backend Improvement labels Jan 8, 2025
@rak3rman rak3rman self-assigned this Jan 8, 2025
@Copilot Copilot bot review requested due to automatic review settings January 8, 2025 22:43

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Copy link

github-actions bot commented Jan 8, 2025

Pull Request Smart Comments
Assignee(s): Mark tasks as they are completed. Code Reviewer(s): Ensure all tasks are complete and follow best standards before approving.

  • Assigned at least one (1+) experienced code reviewer and notified them requesting a review
  • Assigned all contributors as assignees
  • Assigned relevant labels that are a subset or related to the parent issue's labels
  • Checked that PR description contains a quick summary of work accomplished and uses issue closing words
  • Checked that completed tasks in related issue(s) are marked accordingly
  • Checked that PR title is descriptive and follows commit message semantics

@rak3rman rak3rman requested a review from Copilot January 8, 2025 22:45

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

hono/src/services/outfits.ts:335

  • The filter check '.filter((id) => id)' is redundant since 'coreItems' is expected to be an array of strings. It should be removed to simplify the code.
.filter((id) => id)
@rak3rman rak3rman merged commit 74d468f into main Jan 8, 2025
9 checks passed
@rak3rman rak3rman deleted the radison/outfit-alg-v0.0.1 branch January 8, 2025 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Related to the hono backend Improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant