Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add drizzle database connection as middleware #32

Merged
merged 11 commits into from
Feb 6, 2024
Merged

feat: add drizzle database connection as middleware #32

merged 11 commits into from
Feb 6, 2024

Conversation

vincentdo1
Copy link
Collaborator

No description provided.

@vincentdo1 vincentdo1 requested a review from rak3rman February 4, 2024 22:59
@rak3rman rak3rman added the feat New actionable feature that impacts user experience label Feb 4, 2024
@rak3rman rak3rman added this to the v0.0.1 milestone Feb 4, 2024
rak3rman
rak3rman requested changes Feb 4, 2024
View reviewed changes
Copy link
Member

@rak3rman rak3rman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great first pass. I'm glad you were able to get the middleware going. Just a few nits that may take some thought.

@vincentdo1 vincentdo1 requested a review from rak3rman February 5, 2024 19:26
@rak3rman rak3rman self-assigned this Feb 6, 2024
rak3rman
rak3rman requested changes Feb 6, 2024
View reviewed changes
@rak3rman rak3rman requested a review from SengdowJones February 6, 2024 19:12
SengdowJones
SengdowJones approved these changes Feb 6, 2024
View reviewed changes
Copy link
Member

@SengdowJones SengdowJones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!👍

@vincentdo1 vincentdo1 merged commit 2f920b5 into main Feb 6, 2024
3 checks passed
@vincentdo1 vincentdo1 deleted the 29-drizzle-db-middleware branch February 6, 2024 19:21
@rak3rman rak3rman linked an issue Feb 6, 2024 that may be closed by this pull request
Add drizzle db connection setup as middleware #29
Closed
rak3rman added a commit that referenced this pull request Feb 7, 2024
@rak3rman
Revert "feat: add drizzle database connection as middleware (#32)"
3085217 
This reverts commit 2f920b5.
rak3rman added a commit that referenced this pull request Feb 7, 2024
@rak3rman
Revert "feat: add drizzle database connection as middleware (#32)"
827ffc2 
This reverts commit 2f920b5.
@rak3rman rak3rman mentioned this pull request Feb 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rak3rman rak3rman rak3rman approved these changes

@SengdowJones SengdowJones SengdowJones approved these changes

Assignees

@rak3rman rak3rman

@vincentdo1 vincentdo1

Labels
feat New actionable feature that impacts user experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add drizzle db connection setup as middleware
3 participants
@vincentdo1 @rak3rman @SengdowJones