Skip to content
This repository was archived by the owner on May 11, 2023. It is now read-only.

Fix missing shared libraries problem on M1 Macs #98

Merged
merged 1 commit into from
May 17, 2022

Conversation

adaszko
Copy link
Contributor

@adaszko adaszko commented May 10, 2022

Fix missing shared libraries problem on M1 Macs: libssl and libusb.

A workaround in libusb-sys has been implemented. The bug is yet to be reported upstream to libusb. It's to do with missing libobj.a static library on new versions of macOS. libusb pkg-config .pc file seems to be assuming they're still there.

Once the issue is resolved upstream, the workaround in libusb-sys will be removed.

According to my understanding, the static build of libusb1-sys on macOS fails because of a bug in rustc.

IMO, it's best if we maintain a version of libusb1-sys with a workaround (referenced in this PR via patch.io-crates) until a rustc fix gets released.

@adaszko adaszko marked this pull request as ready for review May 12, 2022 07:20
@adaszko adaszko requested a review from cloudhead as a code owner May 12, 2022 07:20
@adaszko
Copy link
Contributor Author

adaszko commented May 12, 2022

I've also opened a PR in libusb-sys.

Verified

This commit was signed with the committer’s verified signature.
cloudhead Alexis Sellier
@cloudhead cloudhead force-pushed the adaszko/macos-m1-fix branch from 77edb7e to 589ec2a Compare May 17, 2022 08:31
@cloudhead cloudhead merged commit 589ec2a into master May 17, 2022
@cloudhead cloudhead deleted the adaszko/macos-m1-fix branch May 17, 2022 08:31
@cloudhead cloudhead restored the adaszko/macos-m1-fix branch May 17, 2022 08:35
@cloudhead
Copy link
Contributor

Woops, this doesn't build.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants