-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies #622
Update dependencies #622
Conversation
It seems that the build smoke test is failing because of microsoft/playwright#21106 |
Oh, good catch. I was trying to figure this out yesterday, but couldn't find what was wrong with it. |
1142faa
to
aedd6fc
Compare
There seems to be a regression in FF: microsoft/playwright#21145. |
Maybe we should exclude playwright from this update? Since there are some other dependencies that are either major updates or at least minor ones. |
Yeah, can do. |
Signed-off-by: Rūdolfs Ošiņš <rudolfs@osins.org>
aedd6fc
to
55cc5c3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, seems to work nicely
Hm, on second thought, I think this won't work, because the problem seems to be with the newer firefox browser version. And we don't have a way to not update the browsers when bumping deps. So we either disable the firefox tests or wait for playwright to fix it on their end. |
So we are kinda vendor locked in by Microsoft 😅 |
See microsoft/playwright#21145 for more details. Signed-off-by: Rūdolfs Ošiņš <rudolfs@osins.org>
To keep us up-to-date. This also updates transitive dependencies.