Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use "thiserror" in library code #72

Closed
kim opened this issue Mar 12, 2020 · 2 comments · Fixed by #76
Closed

Use "thiserror" in library code #72

kim opened this issue Mar 12, 2020 · 2 comments · Fixed by #76
Labels
brooming Gotta do whatcha gotta do

Comments

@kim
Copy link
Contributor

kim commented Mar 12, 2020 •
edited
Loading

Instead of failure, as per radicle-dev/radicle-decisions#2

It's still not so clear how we want to deal with opaque errors -- perhaps a library OpaqueError(String)?
@kim kim added the brooming Gotta do whatcha gotta do label Mar 12, 2020
@xla
Copy link
Contributor

xla commented Mar 12, 2020

@kim I believe you are referring to radicle-dev/radicle-decisions#2.

@kim
Copy link
Contributor Author

kim commented Mar 12, 2020

Absolutely

kim added a commit that referenced this issue Mar 18, 2020
@kim
Errors: thiserror + anyhow instead of failure
6d3a54e 
Fixes #72
@kim kim mentioned this issue Mar 18, 2020
Merged
kim added a commit that referenced this issue Mar 19, 2020
@kim
Errors: thiserror + anyhow instead of failure
fccc147 
Fixes #72
@kim kim closed this as completed in cb778e7 Mar 19, 2020
@kim kim closed this as completed in #76 Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
brooming Gotta do whatcha gotta do
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Errors: thiserror + anyhow instead of failure radicle-dev/radicle-link
2 participants
@xla @kim