Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Node.js from 10 to 22 #387

Merged
merged 1 commit into from
Oct 20, 2024
Merged

Update Node.js from 10 to 22 #387

merged 1 commit into from
Oct 20, 2024

Conversation

paskal
Copy link
Collaborator

@paskal paskal commented Aug 11, 2024

  • Enabled the --openssl-legacy-provider flag for the old Webpack version.
  • Replaced the deprecated node-sass (which relies on Python 2) with sass, which doesn't require a build.
  • Updated package-lock.json with the new version (same packages except for the change to sass).
  • Fixed Webpack config to use sass instead of node-sass and committed changes to manifest.json.

The only change, surprisingly, is in the archive RSS podcast-archives .rss <itunes:subtitle> field content. You can see all the changes in a single table at this link: https://jsfiddle.net/y5f9jzo4/. I've checked manually, and run in Docker for node10 vs run on node22 vs local run against the master generate three different rss results affecting only podcast-archives-short.rss and podcast-archives.rss. I'm yet trying to figure out what's the cause of the difference, as no generated files supposed to be used,

You'll need to change netlify node version to 22 in order for CI to work: current error is because node older than 12 is used.

@paskal paskal force-pushed the node_22 branch 6 times, most recently from a9ca8bc to 3a03e62 Compare August 11, 2024 12:26
@paskal paskal force-pushed the node_22 branch 3 times, most recently from 8ec2cbf to db8ffc3 Compare October 13, 2024 21:05
- Enabled the `--openssl-legacy-provider` flag for the old Webpack
version.
- Replaced the deprecated `node-sass` (which relies on Python 2) with
`sass`, which doesn't require a build.
- Updated `package-lock.json` with the new version (same packages except
 for the change to `sass`).
- Fixed Webpack config to use `sass` instead of `node-sass` and
committed changes to `manifest.json`.

The only change, surprisingly, is in the archive RSS `podcast-archives
.rss` `<itunes:subtitle>` field content. You can see all the changes in
a single table at this link:
https://jsfiddle.net/y5f9jzo4/
@umputun umputun merged commit 433adbd into radio-t:master Oct 20, 2024
1 of 6 checks passed
@paskal paskal deleted the node_22 branch October 20, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants