Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Svelte5 migration + complete rewrite #6

Draft
wants to merge 51 commits into
base: master
Choose a base branch
from
Draft

Svelte5 migration + complete rewrite #6

wants to merge 51 commits into from

Conversation

romaindurand
Copy link
Collaborator

@romaindurand romaindurand commented Nov 5, 2024 •
edited
Loading

  • Doesn't require to install leaflet or leaflet.markercluster, most useful types are also exported from the package
  • Support for SSR
  • Reactivity is handled with runes
  • leaflet events are available directly from components with the new oneventname syntax, using the bindable instance is rarely needed
  • All component attributes and options are reactive, except for the one that would require to re-instanciate the leaflet class
  • Should be more reliable since contexts does not rely on components rendering anymore (no more await tick() to wait for parent context to be defined)

@romaindurand romaindurand marked this pull request as draft November 5, 2024 13:24
@romaindurand
project reset + working Map
5509e16
@romaindurand
wip : migrating Map to svelte5 syntaxes
6555227
@romaindurand
wip
c7181e3
@romaindurand
wip : instance types + props reactivity
0cd7366
@romaindurand
implement reactivity for all boolean map options
dbcaf71
@romaindurand
implement reactivity for all number map options
78502eb
@romaindurand
wip : implement reactivity for all other props
c7ba601
@romaindurand
implement reactivity for all other map options
daf5bc0
@romaindurand
implement geolocation button
ca46cba
@romaindurand
execute svelte 5 migration script
b9d8139
@romaindurand
init markers
e5b3f42
@romaindurand
WIP : custom marker
a704615
@romaindurand
wip : markers options reactivity
fe5436d
@romaindurand
DivIcon + Marker refactoring
334f15e
@romaindurand
implement reactivity for numeric marker options
ee7dd69
@romaindurand
handle reactivity for icon + title marker option
1a2512d
@romaindurand
format with trailing comma
d00544c
@romaindurand
marker reactivity done
2891d51
@romaindurand
DivIcon instance, Popup + events wip , bindable map markers wip, gene…
4de16c9 
…ric getUpdateProps wip
@romaindurand
implement reactivity for number and string Popup options
bd078b3
@romaindurand
wip : tuple popup options reactivity
daf0b5b
@romaindurand
handle popup tuple options reactivity
cd82d2f
@romaindurand
implements MarkerCluster
59b2219
@romaindurand
rebuild lib using new svelte CLI
2f99b87
@romaindurand
Too many changes 💀
9f4b086 
- typed leaflet event sourceTarget
- handle components destroy
- hide DivIcon & Popup html child from page
- fixed map not firing load event with no location control
- added too many await tick(), needs refactornig
- improved cluster demo page
- added list/marker two-way binding demo page
@romaindurand
Context refactoring
1324e78 
- Removes all await tick()
- Prevents children from being rendered before initializing component leaflet instance, except for components that only have html as children
- fixes Popup content setup, DivIcon should be a direct children of Marker, not Popup
@romaindurand
create Icon component, init in-component documentation
b5508da
@romaindurand
explicit use of window.L
83d71ed 
never using static imports of leaflet allow to be SSR compatible
@romaindurand
many changes
7f5c5ee 
- implements reactivity for all Polygon options and props
- Controls/Details style refactoring
- events reorganisation
@romaindurand
split LocateControl in its own component, bind MarkerClusterGroup eve…
17a2489 
…nts, add skeleton, handle dark mode
@romaindurand
fir map load event + cosmetic tweaks
8fe895c
@romaindurand
custom cluster marker icon, implement Polyline
4cf3ea2
@romaindurand
1.0.0-next.0
4181e7b
@romaindurand
svelte check fix
e76bfb0
@romaindurand
LeafletEvent with sourceTarget type, export all components
99ed9c8
@romaindurand
1.0.0-next.1
85de501
@romaindurand
LocateControl, rename components helper files, update readme wip
6a0fb12
@romaindurand
1.0.0-next.2
92a5f4c
@romaindurand
handle tooltip
ddb1136
@romaindurand
reactive tooltip demo
291b2a3
@romaindurand
TileLayer, TileLayerWMS
767fb49
@romaindurand
image + video overlay
786d4bf
@romaindurand
Circle, CircleMarker, LayersControl wip, Rectangle, SVGOverlay
ccc8db5
@romaindurand
LaryersControl + base layers and overlays stores, Demo component (cod…
2a12f35 
…e + iframe) POC
@romaindurand
add npm publish + overlay store for image and video overlays
225c0d2
@romaindurand
github publish on stable versions only
6d78254
@romaindurand
github action to publish next tags
fb7eb8c
@romaindurand
1.0.0-next.3
ed0aa92
@romaindurand
docs wip
c82d26a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@romaindurand