Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Layout class #4

Merged
merged 6 commits into from
Sep 30, 2024
Merged

Update Layout class #4

merged 6 commits into from
Sep 30, 2024

Conversation

aknierim
Copy link
Member

@aknierim aknierim commented Sep 27, 2024

  • add new classmethod from_url that requests the layout from a URL
  • improve from_pyvisgen and from_casa classmethods
  • add new utility method that fetches layout name via http-request
  • remove pyvisgen dependency completely

- add new classmethod from_url that requests the layout from a URL
- improve from_pyvisgen and from_casa classmethods
@aknierim aknierim requested a review from tgross03 September 27, 2024 13:06
@aknierim
Copy link
Member Author

Removed pyvisgen dependency from the package

@aknierim aknierim requested a review from Kevin2 September 30, 2024 06:40
Copy link
Member

@Kevin2 Kevin2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aknierim aknierim merged commit 1e18673 into main Sep 30, 2024
@aknierim aknierim deleted the update_layouts branch September 30, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants