Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TS support: Updated package.json to fix export of types #116

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

theRuslan
Copy link
Contributor

@theRuslan theRuslan commented Feb 19, 2024

Latest release breaks TS support with this new settings block:

"exports": {
    ".": {
      "import": "./dist/get-video-id.esm.js",
      "require": "./dist/get-video-id.js",
    }
  }

So we can explicitly export types in this block to fix it.

"exports": {
    ".": {
      "import": "./dist/get-video-id.esm.js",
      "require": "./dist/get-video-id.js",
      "types": "./index.d.ts"
    }
  },

@theRuslan theRuslan changed the title Updated package.json to fix export of types TS support: Updated package.json to fix export of types Feb 19, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0f82588) 99.78% compared to head (475c14b) 99.78%.
Report is 6 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #116   +/-   ##
=======================================
  Coverage   99.78%   99.78%           
=======================================
  Files          12       12           
  Lines         457      457           
=======================================
  Hits          456      456           
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@radiovisual radiovisual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for this! I will add it to a new release right away.

@radiovisual radiovisual merged commit ba9ec4e into radiovisual:master Feb 21, 2024
5 checks passed
@radiovisual
Copy link
Owner

Thanks again @theRuslan, this fix was published in v4.1.5

@theRuslan theRuslan deleted the fix-types-export branch February 21, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants