Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced get_new_version (depends on #35) #36

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Enhanced get_new_version (depends on #35) #36

wants to merge 2 commits into from

Conversation

davidmosterd
Copy link
Contributor

The check for the version is now just an call to empty() as that should do?

It then assumes 'null' as its default value and tries to get a new version. Which should always work, but if it does not it returns this 'null'

Maybe for better working the fallback should return sooner or the orginal transient should be returned or the 'null' could be converted to ''

Depends on #35. Or we wait for the previous commit.

@davidmosterd
Copy link
Contributor Author

Coud you/we look into this with some prio? As of now, the current code gives fatal errors when WP_Error is indeed triggered. Regardless of why there is a WP_Error, this really breaks the code badly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant