-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: filtering of recipe table #74
Conversation
Signed-off-by: Christian Lechner <lechnerc77@users.noreply.github.com>
Signed-off-by: Christian Lechner <lechnerc77@users.noreply.github.com>
2dff57f
to
9d8d556
Compare
Thanks @lechnerc77! We'll take a look at your PR today. |
Thank you so much @lechnerc77, these changes look good. Could you please add a screen shot of the new UI capturing the change? |
@nithyatsu sure I can add screenshots: Sorting of table Table filter via filter area Table Filter via toolbar And when looking at the screenshots, there seems to be glitch in the toolbar that leads to a weird padding of the |
@lechnerc77 thank you so much for the screenshots, they look great! I will take a look at the code tomorrow to understand the overlap issue with the text and get back to you. |
return ( | ||
<Table | ||
title={title || 'Recipes'} | ||
options={{ search: false, paging: false }} | ||
options={{ search: true, paging: false, sorting: true }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since we have the TableFilter, we can turn of the search so that the toolbar disappears.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the search. I changed the filtering option for Name to multi-select to be consistent with the other options
I did not find a way to get the overlapping text issue solved. But since we are now dropping the toolbar and the title, we should be good. |
type: 'multiple-select', | ||
}, | ||
]; | ||
|
||
return ( | ||
<Table | ||
title={title || 'Recipes'} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The title is redundant since we have the page title set already. Therefore we can remove this. I will make sure to remove the redundant title from a couple of other pages too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Good to hear that I did not overlook something here! |
Signed-off-by: Christian Lechner <lechnerc77@users.noreply.github.com>
Signed-off-by: Christian Lechner <lechnerc77@users.noreply.github.com>
8ffa99a
to
86336db
Compare
Signed-off-by: Christian Lechner <lechnerc77@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @lechnerc77
This PR introduces filtering and sorting for the recipe table.
This covers parts of the rquirements from issue #32. The resource table is not yet enabled for sorting and filtering. This requires a bit more work due to the setup of the table.
AB#12039