Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes incorrect rad workspace switch example #1029

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Fixes incorrect rad workspace switch example #1029

merged 1 commit into from
Feb 2, 2024

Conversation

PalmEmanuel
Copy link
Contributor

Please follow this checklist before submitting:

  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

Updated incorrect example of CLI command for rad workspace switch which was using rad env switch.

Signed-off-by: Emanuel Palm <emanuel+github@pipe.how>
Copy link
Contributor

@AaronCrawfis AaronCrawfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@PalmEmanuel
Copy link
Contributor Author

I followed the [edit this page] link from Docs but now I noticed it automatically PR:d to v0.30 instead of v0.29, hope that's fine otherwise I'll resubmit it!

@AaronCrawfis AaronCrawfis merged commit d3c8a99 into radius-project:v0.30 Feb 2, 2024
8 of 9 checks passed
@AaronCrawfis
Copy link
Contributor

I followed the [edit this page] link from Docs but now I noticed it automatically PR:d to v0.30 instead of v0.29, hope that's fine otherwise I'll resubmit it!

No problem, we're going to be releasing 0.30 later today so this is the correct branch. Thanks!

@PalmEmanuel PalmEmanuel deleted the patch-1 branch February 2, 2024 17:47
Reshrahim pushed a commit to Reshrahim/docs that referenced this pull request Feb 9, 2024
Signed-off-by: Emanuel Palm <emanuel+github@pipe.how>
Signed-off-by: Reshma Abdul Rahim <reshmarahim.abdul@microsoft.com>
Reshrahim added a commit that referenced this pull request Feb 21, 2024
* Hide old  application graph page

Signed-off-by: Reshma Abdul Rahim <reshmarahim.abdul@microsoft.com>

* Update docs/content/concepts/why-radius/application-graph/index.md

Signed-off-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com>

* Revamp contribution guides

Signed-off-by: Reshma Abdul Rahim <reshmarahim.abdul@microsoft.com>

* Remove untracked changes

* Remove untracked changes

* Remove untracked changes

* fix workspace switch cli example (#1029)

Signed-off-by: Emanuel Palm <emanuel+github@pipe.how>
Signed-off-by: Reshma Abdul Rahim <reshmarahim.abdul@microsoft.com>

* Hide old  application graph page

Signed-off-by: Reshma Abdul Rahim <reshmarahim.abdul@microsoft.com>

* Update docs/content/concepts/why-radius/application-graph/index.md

Signed-off-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com>
Signed-off-by: Reshma Abdul Rahim <reshmarahim.abdul@microsoft.com>

* Revamp contribution guides

Signed-off-by: Reshma Abdul Rahim <reshmarahim.abdul@microsoft.com>

* Remove untracked changes

Signed-off-by: Reshma Abdul Rahim <reshmarahim.abdul@microsoft.com>

* Remove untracked changes

Signed-off-by: Reshma Abdul Rahim <reshmarahim.abdul@microsoft.com>

* Remove untracked changes

Signed-off-by: Reshma Abdul Rahim <reshmarahim.abdul@microsoft.com>

* Make community tope level

Signed-off-by: Reshma Abdul Rahim <reshmarahim.abdul@microsoft.com>

* Delete package-lock.json

Signed-off-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com>

* address feedback

Signed-off-by: Reshma Abdul Rahim <reshmarahim.abdul@microsoft.com>

* Update docs/content/contributing/overview/index.md

Co-authored-by: Aaron Crawfis <Aaron.Crawfis@microsoft.com>
Signed-off-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com>

* Remove changes to package-lock.json

Signed-off-by: Reshma Abdul Rahim <reshmarahim.abdul@microsoft.com>

* Restore package-lock.json

Signed-off-by: Reshma Abdul Rahim <reshmarahim.abdul@microsoft.com>

* Resore package-lock.json

Signed-off-by: Reshma Abdul Rahim <reshmarahim.abdul@microsoft.com>

* Add aliase

Signed-off-by: Reshma Abdul Rahim <reshmarahim.abdul@microsoft.com>

* Address feedback

Signed-off-by: Reshma Abdul Rahim <reshmarahim.abdul@microsoft.com>

* Address feedback

Signed-off-by: Reshma Abdul Rahim <reshmarahim.abdul@microsoft.com>

---------

Signed-off-by: Reshma Abdul Rahim <reshmarahim.abdul@microsoft.com>
Signed-off-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com>
Signed-off-by: Emanuel Palm <emanuel+github@pipe.how>
Co-authored-by: Emanuel Palm <emanuel+github@pipe.how>
Co-authored-by: Aaron Crawfis <Aaron.Crawfis@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants