Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation for Azure workload identity #1138

Merged
merged 17 commits into from
Jun 21, 2024
Merged

Add documentation for Azure workload identity #1138

merged 17 commits into from
Jun 21, 2024

Conversation

Reshrahim
Copy link
Contributor

Thank you for helping make the Radius documentation better!

Please follow this checklist before submitting:

  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

This PR covers the Docs for Azure workload identity

Issue reference

@Reshrahim
Add workload identity docs
328015e 
Signed-off-by: Reshma Abdul Rahim <reshmarahim.abdul@microsoft.com>
@Reshrahim Reshrahim requested review from a team as code owners June 19, 2024 02:04
@Reshrahim
Add workload identity docs
a035c9d 
Signed-off-by: Reshma Abdul Rahim <reshmarahim.abdul@microsoft.com>
@willdavsmith
Updating with wi script
0e1854e 
Signed-off-by: willdavsmith <willdavsmith@gmail.com>
@willdavsmith
oops
d5b0514 
Signed-off-by: willdavsmith <willdavsmith@gmail.com>
@willdavsmith
edits
ad44d97 
Signed-off-by: willdavsmith <willdavsmith@gmail.com>
@Reshrahim
Add dets
86d0955 
Signed-off-by: Reshma Abdul Rahim <reshmarahim.abdul@microsoft.com>
@Reshrahim
Add dets
49fee37 
Signed-off-by: Reshma Abdul Rahim <reshmarahim.abdul@microsoft.com>
Reshrahim added 2 commits June 20, 2024 19:24
@Reshrahim
Fix spelling errors
4559d40 
Signed-off-by: Reshma Abdul Rahim <reshmarahim.abdul@microsoft.com>
@Reshrahim
Fix snippets visualization
b179092 
Signed-off-by: Reshma Abdul Rahim <reshmarahim.abdul@microsoft.com>
@Reshrahim
Update docs/content/guides/operations/providers/azure-provider/howto-…
c5bdfd1 
…azure-provider-wi/index.md

Signed-off-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com>
@Reshrahim
Update docs/content/guides/operations/providers/azure-provider/howto-…
df06693 
…azure-provider-wi/index.md

Signed-off-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com>
@Reshrahim @willtsai
Update docs/content/guides/operations/providers/azure-provider/howto-…
55ff14c 
…azure-provider-sp/index.md

Co-authored-by: Will <28876888+willtsai@users.noreply.github.com>
Signed-off-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com>
@Reshrahim
Address feedback
bacca37 
Signed-off-by: Reshma Abdul Rahim <reshmarahim.abdul@microsoft.com>
willtsai
willtsai approved these changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@willtsai willtsai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please get the spellcheck to pass before merging.

@Reshrahim
Fix spelling
f646957 
Signed-off-by: Reshma Abdul Rahim <reshmarahim.abdul@microsoft.com>
@Reshrahim
Fix spelling
f6ab833 
Signed-off-by: Reshma Abdul Rahim <reshmarahim.abdul@microsoft.com>
@Reshrahim Reshrahim merged commit d1d195b into edge Jun 21, 2024
9 checks passed
@Reshrahim Reshrahim deleted the re/wi branch June 21, 2024 16:37
@Reshrahim Reshrahim mentioned this pull request Sep 27, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willtsai willtsai willtsai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Reshrahim @willtsai @willdavsmith