Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just so I know what's going on ... does this command actually disable the built-in ingress + load balancer?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/cc @Reshrahim @willtsai
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rynowak K3d has an external load balancer that can be disabled, but the configuration in this PR does not do that. The external LB is an nginx instance that runs as a container and routes traffic from the host machine into the k3d cluster container. We could disable it by passing
--no-lb
to thek3d cluster create
command, i.e.k3d cluster create --no-lib
, however, we need the routing from the host machine into the cluster that is provided by the nginx container.Inside the k3d cluster there is an internal load balancer called
servicelb
that distributes traffic. That is the one we are disabling with this configuration.