-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dapr tutorial Application ID updates #913
Conversation
Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>
Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>
1. Begin in a new directory for your application: | ||
|
||
```bash | ||
mkdir rad-dapr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This conflicts with https://github.com/radius-project/samples/pull/654/files#r1372333903. We should have the directory match the app name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>
Thank you for helping make the Radius documentation better!
Please follow this checklist before submitting:
In addition, please fill out the following to help reviewers understand this pull request:
Description
Corrections to the bicep definitions to use CLI-injected app id instead of custom-defined app id.
Auto-generated description
🤖 Generated by Copilot at ce7bf4f
Summary
📝🛠️🚀
Improved the
tutorial-dapr
document and bicep file to make them easier to use and understand. Parameterized the application ID in thedapr.bicep
file and clarified the prerequisites and cleanup steps in thetutorial-dapr/index.md
file.Walkthrough
dapr.bicep
file to enable automatic injection and customization (link, link, link, link)tutorial-dapr/index.md
file to include setting up a Kubernetes cluster and initializing a Radius environment (link)tutorial-dapr/index.md
file to use the default application name and format the keyboard shortcut consistently (link)Issue reference
Related to: radius-project/samples#654
Fixes: radius-project/samples#654