Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dapr tutorial Application ID updates #913

Merged
merged 3 commits into from
Oct 26, 2023
Merged

Conversation

willtsai
Copy link
Contributor

@willtsai willtsai commented Oct 25, 2023

Thank you for helping make the Radius documentation better!

Please follow this checklist before submitting:

  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

Corrections to the bicep definitions to use CLI-injected app id instead of custom-defined app id.

Auto-generated description

🤖 Generated by Copilot at ce7bf4f

Summary

📝🛠️🚀

Improved the tutorial-dapr document and bicep file to make them easier to use and understand. Parameterized the application ID in the dapr.bicep file and clarified the prerequisites and cleanup steps in the tutorial-dapr/index.md file.

dapr.bicep changed
Parameter for app ID
Autumn of hard code

Walkthrough

  • Add and document a parameter for the application ID in the dapr.bicep file to enable automatic injection and customization (link, link, link, link)
  • Update the prerequisites section in the tutorial-dapr/index.md file to include setting up a Kubernetes cluster and initializing a Radius environment (link)
  • Simplify the cleanup section in the tutorial-dapr/index.md file to use the default application name and format the keyboard shortcut consistently (link)

Issue reference

Related to: radius-project/samples#654
Fixes: radius-project/samples#654

Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>
@willtsai willtsai requested review from a team as code owners October 25, 2023 22:23
@willtsai willtsai temporarily deployed to latest October 25, 2023 22:24 — with GitHub Actions Inactive
Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>
1. Begin in a new directory for your application:

```bash
mkdir rad-dapr
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This conflicts with https://github.com/radius-project/samples/pull/654/files#r1372333903. We should have the directory match the app name

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>
@willtsai willtsai merged commit c70cb13 into v0.26 Oct 26, 2023
8 of 9 checks passed
@willtsai willtsai deleted the willtsai/dapr-tutorial-app-fix branch October 26, 2023 22:25
@willtsai willtsai temporarily deployed to latest October 26, 2023 22:26 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants