Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remaining types to dev recipes processing #5778

Merged
merged 2 commits into from
Jun 21, 2023
Merged

Conversation

AaronCrawfis
Copy link
Contributor

@AaronCrawfis AaronCrawfis commented Jun 21, 2023

Description

Today we have hard-coded support for redis and mongo types for dev recipes.

This PR adds the remaining types now that they have Recipes support.

Issue reference

Partially addresses #5775

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Adds necessary unit tests for change
  • Adds necessary E2E tests for change
  • Unit tests passing
  • Extended the documentation / Created issue for it

Auto-generated summary

🤖 Generated by Copilot at 5af7734

Summary

🚀🧪🔗

Updated getLinkType function and tests to support more resource types for linking applications. The function now handles dapr, rabbit mq, and sql resources based on the linkrp constants.

To link apps to services with ease
We updated the getLinkType function, please
It supports more resource types
Like dapr and rabbit mq bites
And sql databases that store keys

Walkthrough

  • Add support for more resource types in getLinkType function (link)
  • Update Test_getLinkType function to include test cases for new resource types and modify invalid case (link, link)

@AaronCrawfis AaronCrawfis requested a review from a team as a code owner June 21, 2023 19:58
@github-actions
Copy link

github-actions bot commented Jun 21, 2023

Radius functional test overview

🔍 Go to test action run

Name Value
Repository project-radius/radius
Commit ref f80b9df
Unique ID cf5dce2c27
Image tag pr-cf5dce2c27
Click here to see the list of tools in the current test run
  • gotestsum 1.10.0
  • KinD: v0.18.0
  • Dapr: 1.10.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.0.0
  • recipe location radiusdev.azurecr.io/test/functional/corerp/recipes/<name>:pr-cf5dce2c27
  • appcore-rp test image location: radiusdev.azurecr.io/appcore-rp:pr-cf5dce2c27
  • ucp test image location: radiusdev.azurecr.io/ucpd:pr-cf5dce2c27

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp functional tests...
⌛ Starting corerp functional tests...
✅ samples functional tests succeeded
✅ ucp functional tests succeeded
✅ corerp functional tests succeeded

@github-actions
Copy link

github-actions bot commented Jun 21, 2023

Test Results

2 634 tests  +5   2 625 ✔️ +5   1m 58s ⏱️ -1s
   236 suites ±0          9 💤 ±0 
       1 files   ±0          0 ±0 

Results for commit 5af7734. ± Comparison against base commit c2ca7bc.

This pull request removes 2 and adds 7 tests. Note that renamed tests count towards both.
github.com/project-radius/radius/pkg/armrpc/frontend/controller ‑ TestValidateEtag_IfMatch/0dc7849d-59fc-4055-acda-fb0e96e97f78
github.com/project-radius/radius/pkg/armrpc/frontend/controller ‑ TestValidateEtag_IfMatch/0dc7849d-59fc-4055-acda-fb0e96e97f78#01
github.com/project-radius/radius/pkg/armrpc/frontend/controller ‑ TestValidateEtag_IfMatch/08ecbc85-86b7-459e-b1da-3283594e9f80
github.com/project-radius/radius/pkg/armrpc/frontend/controller ‑ TestValidateEtag_IfMatch/08ecbc85-86b7-459e-b1da-3283594e9f80#01
github.com/project-radius/radius/pkg/cli/cmd/radinit ‑ Test_getLinkType/Dapr_PubSub_Link_Type
github.com/project-radius/radius/pkg/cli/cmd/radinit ‑ Test_getLinkType/Dapr_Secret_Store_Link_Type
github.com/project-radius/radius/pkg/cli/cmd/radinit ‑ Test_getLinkType/Dapr_State_Store_Link_Type
github.com/project-radius/radius/pkg/cli/cmd/radinit ‑ Test_getLinkType/Rabbit_MQ_Link_Type
github.com/project-radius/radius/pkg/cli/cmd/radinit ‑ Test_getLinkType/SQL_Database_Link_Type

♻️ This comment has been updated with latest results.

@github-actions
Copy link

65.7

For the detailed report, please go to Checks tab, click Build and Test, and then download unit_test_coverage artifact at the bottom of build page.

  • Your PR branch coverage: 65.7 %
  • main branch coverage: 65.7 %
  • diff coverage: 0 %

The coverage result does not include the functional test coverage.

@github-actions
Copy link

github-actions bot commented Jun 21, 2023

Radius functional test overview

🔍 Go to test action run

Name Value
Repository project-radius/radius
Commit ref 5af7734
Unique ID 5d9612366e
Image tag pr-5d9612366e
Click here to see the list of tools in the current test run
  • gotestsum 1.10.0
  • KinD: v0.18.0
  • Dapr: 1.10.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.0.0
  • recipe location radiusdev.azurecr.io/test/functional/corerp/recipes/<name>:pr-5d9612366e
  • appcore-rp test image location: radiusdev.azurecr.io/appcore-rp:pr-5d9612366e
  • ucp test image location: radiusdev.azurecr.io/ucpd:pr-5d9612366e

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting samples functional tests...
⌛ Starting corerp functional tests...
⌛ Starting ucp functional tests...
✅ samples functional tests succeeded
✅ ucp functional tests succeeded
❌ corerp functional test failed. Please check the logs for more details
⌛ Starting corerp functional tests...
✅ corerp functional tests succeeded

@github-actions
Copy link

65.7

For the detailed report, please go to Checks tab, click Build and Test, and then download unit_test_coverage artifact at the bottom of build page.

  • Your PR branch coverage: 65.7 %
  • main branch coverage: 65.7 %
  • diff coverage: 0 %

The coverage result does not include the functional test coverage.

@rynowak
Copy link
Contributor

rynowak commented Jun 21, 2023

@ytimocin - do we have a work item to remove this hardcoding?

@AaronCrawfis
Copy link
Contributor Author

@ytimocin - do we have a work item to remove this hardcoding?

Wouldn't it be #4982?

@ytimocin
Copy link
Contributor

@ytimocin - do we have a work item to remove this hardcoding?

Wouldn't it be #4982?

Created an issue just in case: #5785. cc/ @rynowak @AaronCrawfis

@AaronCrawfis AaronCrawfis merged commit 76f9500 into main Jun 21, 2023
@AaronCrawfis AaronCrawfis deleted the aacrawfi/dev-recipes branch June 21, 2023 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants