Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AWS/Azure to required features list. #7218

Merged
merged 7 commits into from
Mar 1, 2024

Conversation

vinayada1
Copy link
Contributor

@vinayada1 vinayada1 commented Feb 29, 2024

Description

As a part of #6588, as proposed by radius-project/design-notes#35, we will use RequiredFeatures check to separate AWS and Azure specific tests. This is Part1 of a multi-part PR to change the organization of the tests

Type of change

Fixes: A part of #6588 but multiple PRs to follow to fix completely

Signed-off-by: vinayada1 <28875764+vinayada1@users.noreply.github.com>
Signed-off-by: vinayada1 <28875764+vinayada1@users.noreply.github.com>
@vinayada1 vinayada1 requested review from a team as code owners February 29, 2024 19:40
@radius-functional-tests
Copy link

radius-functional-tests bot commented Feb 29, 2024

Radius functional test overview

🔍 Go to test action run

Name Value
Repository test-org-admin/radius-main
Commit ref 245d2df
Unique ID ce9d4454f5
Image tag pr-ce9d4454f5
Click here to see the list of tools in the current test run
  • gotestsum 1.10.0
  • KinD: v0.20.0
  • Dapr: 1.12.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.1.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/functional/shared/recipes/<name>:pr-ce9d4454f5
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-ce9d4454f5
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-ce9d4454f5
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-ce9d4454f5
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting daprrp functional tests...
⌛ Starting shared functional tests...
⌛ Starting kubernetes functional tests...
⌛ Starting ucp functional tests...
⌛ Starting msgrp functional tests...
⌛ Starting samples functional tests...
⌛ Starting datastoresrp functional tests...
✅ kubernetes functional tests succeeded
✅ msgrp functional tests succeeded
✅ ucp functional tests succeeded
✅ samples functional tests succeeded
✅ daprrp functional tests succeeded
✅ datastoresrp functional tests succeeded
✅ shared functional tests succeeded

@@ -129,5 +129,6 @@ func Test_AWS_S3Bucket_Existing(t *testing.T) {
},
})

test.RequiredFeatures = []shared.RequiredFeature{shared.FeatureAWS}
Copy link
Contributor Author

@vinayada1 vinayada1 Feb 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar changes will be made in subsequent PRs once the tests are separated out and reorganized

@radius-functional-tests
Copy link

radius-functional-tests bot commented Feb 29, 2024

Radius functional test overview

🔍 Go to test action run

Name Value
Repository test-org-admin/radius-main
Commit ref 88927d7
Unique ID ecfe6277a7
Image tag pr-ecfe6277a7
Click here to see the list of tools in the current test run
  • gotestsum 1.10.0
  • KinD: v0.20.0
  • Dapr: 1.12.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.1.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/functional/shared/recipes/<name>:pr-ecfe6277a7
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-ecfe6277a7
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-ecfe6277a7
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-ecfe6277a7
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting daprrp functional tests...
⌛ Starting datastoresrp functional tests...
⌛ Starting shared functional tests...
⌛ Starting ucp functional tests...
⌛ Starting kubernetes functional tests...
⌛ Starting samples functional tests...
⌛ Starting msgrp functional tests...
✅ kubernetes functional tests succeeded
✅ samples functional tests succeeded
✅ msgrp functional tests succeeded
✅ daprrp functional tests succeeded
✅ ucp functional tests succeeded
✅ datastoresrp functional tests succeeded
❌ shared functional test failed. Please check the logs for more details
⌛ Starting shared functional tests...
✅ shared functional tests succeeded

@vinayada1 vinayada1 changed the title Add AWS/Azure to required features list. Test reorganization: Part1 - Add AWS/Azure to required features list. Feb 29, 2024
vinayada1 and others added 2 commits February 29, 2024 16:29
Co-authored-by: Young Bu Park <youngp@microsoft.com>
Signed-off-by: vinayada1 <28875764+vinayada1@users.noreply.github.com>
Co-authored-by: Young Bu Park <youngp@microsoft.com>
Signed-off-by: vinayada1 <28875764+vinayada1@users.noreply.github.com>
@vinayada1 vinayada1 changed the title Test reorganization: Part1 - Add AWS/Azure to required features list. Add AWS/Azure to required features list. Mar 1, 2024
@vinayada1 vinayada1 temporarily deployed to functional-tests March 1, 2024 00:30 — with GitHub Actions Inactive
@radius-functional-tests
Copy link

radius-functional-tests bot commented Mar 1, 2024

Radius functional test overview

🔍 Go to test action run

Name Value
Repository test-org-admin/radius-main
Commit ref 4d05e23
Unique ID 10d854bef5
Image tag pr-10d854bef5
Click here to see the list of tools in the current test run
  • gotestsum 1.10.0
  • KinD: v0.20.0
  • Dapr: 1.12.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.1.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/functional/shared/recipes/<name>:pr-10d854bef5
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-10d854bef5
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-10d854bef5
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-10d854bef5
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
❌ Container images build failed
❌ Test recipe publishing failed

Signed-off-by: vinayada1 <28875764+vinayada1@users.noreply.github.com>
@vinayada1 vinayada1 temporarily deployed to functional-tests March 1, 2024 00:53 — with GitHub Actions Inactive
@radius-functional-tests
Copy link

radius-functional-tests bot commented Mar 1, 2024

Radius functional test overview

🔍 Go to test action run

Name Value
Repository test-org-admin/radius-main
Commit ref 52053de
Unique ID 30e59dda02
Image tag pr-30e59dda02
Click here to see the list of tools in the current test run
  • gotestsum 1.10.0
  • KinD: v0.20.0
  • Dapr: 1.12.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.1.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/functional/shared/recipes/<name>:pr-30e59dda02
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-30e59dda02
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-30e59dda02
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-30e59dda02
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting msgrp functional tests...
⌛ Starting samples functional tests...
⌛ Starting kubernetes functional tests...
⌛ Starting ucp functional tests...
⌛ Starting shared functional tests...
⌛ Starting daprrp functional tests...
⌛ Starting datastoresrp functional tests...
✅ kubernetes functional tests succeeded
✅ samples functional tests succeeded
✅ ucp functional tests succeeded
✅ msgrp functional tests succeeded
✅ daprrp functional tests succeeded
✅ datastoresrp functional tests succeeded
✅ shared functional tests succeeded

@vinayada1 vinayada1 temporarily deployed to functional-tests March 1, 2024 01:07 — with GitHub Actions Inactive
@radius-functional-tests
Copy link

radius-functional-tests bot commented Mar 1, 2024

Radius functional test overview

🔍 Go to test action run

Name Value
Repository test-org-admin/radius-main
Commit ref 20d489a
Unique ID 2c08697295
Image tag pr-2c08697295
Click here to see the list of tools in the current test run
  • gotestsum 1.10.0
  • KinD: v0.20.0
  • Dapr: 1.12.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.1.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/functional/shared/recipes/<name>:pr-2c08697295
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-2c08697295
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-2c08697295
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-2c08697295
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting daprrp functional tests...
⌛ Starting kubernetes functional tests...
⌛ Starting ucp functional tests...
⌛ Starting msgrp functional tests...
⌛ Starting shared functional tests...
⌛ Starting datastoresrp functional tests...
✅ msgrp functional tests succeeded
✅ kubernetes functional tests succeeded
✅ samples functional tests succeeded
✅ ucp functional tests succeeded
✅ daprrp functional tests succeeded
✅ datastoresrp functional tests succeeded
✅ shared functional tests succeeded

@vinayada1 vinayada1 merged commit e3c8e51 into radius-project:main Mar 1, 2024
16 checks passed
willdavsmith pushed a commit to willdavsmith/radius that referenced this pull request Mar 4, 2024
# Description

As a part of radius-project#6588, as proposed by
radius-project/design-notes#35, we will use
RequiredFeatures check to separate AWS and Azure specific tests. This is
Part1 of a multi-part PR to change the organization of the tests

## Type of change

<!--

Please select **one** of the following options that describes your
change and delete the others. Clearly identifying the type of change you
are making will help us review your PR faster, and is used in authoring
release notes.

If you are making a bug fix or functionality change to Radius and do not
have an associated issue link please create one now.

-->

- This pull request adds or changes features of Radius and has an
approved issue (radius-project#6588 ).


<!--

Please update the following to link the associated issue. This is
required for some kinds of changes (see above).

-->

Fixes: A part of radius-project#6588 but multiple PRs to follow to fix completely

---------

Signed-off-by: vinayada1 <28875764+vinayada1@users.noreply.github.com>
Co-authored-by: Young Bu Park <youngp@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants