-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AWS/Azure to required features list. #7218
Add AWS/Azure to required features list. #7218
Conversation
Signed-off-by: vinayada1 <28875764+vinayada1@users.noreply.github.com>
Signed-off-by: vinayada1 <28875764+vinayada1@users.noreply.github.com>
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
@@ -129,5 +129,6 @@ func Test_AWS_S3Bucket_Existing(t *testing.T) { | |||
}, | |||
}) | |||
|
|||
test.RequiredFeatures = []shared.RequiredFeature{shared.FeatureAWS} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar changes will be made in subsequent PRs once the tests are separated out and reorganized
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
Co-authored-by: Young Bu Park <youngp@microsoft.com> Signed-off-by: vinayada1 <28875764+vinayada1@users.noreply.github.com>
Co-authored-by: Young Bu Park <youngp@microsoft.com> Signed-off-by: vinayada1 <28875764+vinayada1@users.noreply.github.com>
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
# Description As a part of radius-project#6588, as proposed by radius-project/design-notes#35, we will use RequiredFeatures check to separate AWS and Azure specific tests. This is Part1 of a multi-part PR to change the organization of the tests ## Type of change <!-- Please select **one** of the following options that describes your change and delete the others. Clearly identifying the type of change you are making will help us review your PR faster, and is used in authoring release notes. If you are making a bug fix or functionality change to Radius and do not have an associated issue link please create one now. --> - This pull request adds or changes features of Radius and has an approved issue (radius-project#6588 ). <!-- Please update the following to link the associated issue. This is required for some kinds of changes (see above). --> Fixes: A part of radius-project#6588 but multiple PRs to follow to fix completely --------- Signed-off-by: vinayada1 <28875764+vinayada1@users.noreply.github.com> Co-authored-by: Young Bu Park <youngp@microsoft.com>
Description
As a part of #6588, as proposed by radius-project/design-notes#35, we will use RequiredFeatures check to separate AWS and Azure specific tests. This is Part1 of a multi-part PR to change the organization of the tests
Type of change
Fixes: A part of #6588 but multiple PRs to follow to fix completely