Add shellcheck extension to dev container #7963

brooke-hamilton · 2024-09-25T18:12:09Z

Description

Adds the shell check extension to the dev container. See https://marketplace.visualstudio.com/items?itemName=timonwong.shellcheck.

Type of change

This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

Fixes: N/A

@rynowak FYI

radius-functional-tests · 2024-09-25T18:19:42Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	brooke-hamilton/radius
Commit ref	`47f09ec`
Unique ID	funcca714fa79f
Image tag	pr-funcca714fa79f

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funcca714fa79f
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funcca714fa79f
controller test image location: ghcr.io/radius-project/dev/controller:pr-funcca714fa79f
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funcca714fa79f
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
⌛ Starting datastoresrp-cloud functional tests...
✅ datastoresrp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded
❌ Test tool installation for ucp-cloud failed. Please check the logs for more details
❌ Failed to install Radius for ucp-cloud functional test. Please check the logs for more details
❌ ucp-cloud functional test failed. Please check the logs for more details

codecov · 2024-09-25T18:24:02Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.17%. Comparing base (125b9fd) to head (87f85e4).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7963      +/-   ##
==========================================
- Coverage   59.21%   59.17%   -0.04%     
==========================================
  Files         579      579              
  Lines       38697    38697              
==========================================
- Hits        22914    22899      -15     
- Misses      14145    14155      +10     
- Partials     1638     1643       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com>

radius-functional-tests · 2024-09-27T07:37:08Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	brooke-hamilton/radius
Commit ref	`7278347`
Unique ID	func958dcfde7b
Image tag	pr-func958dcfde7b

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func958dcfde7b
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func958dcfde7b
controller test image location: ghcr.io/radius-project/dev/controller:pr-func958dcfde7b
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func958dcfde7b
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting datastoresrp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ datastoresrp-cloud functional tests succeeded
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

Signed-off-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com>

radius-functional-tests · 2024-10-24T17:13:13Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	brooke-hamilton/radius
Commit ref	`f5cb333`
Unique ID	funcdffc2b0903
Image tag	pr-funcdffc2b0903

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funcdffc2b0903
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funcdffc2b0903
controller test image location: ghcr.io/radius-project/dev/controller:pr-funcdffc2b0903
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funcdffc2b0903
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

superbeeny · 2024-11-01T17:17:46Z

Anything that can catch me being forgetful before the push is awesome, along the same lines how do folk feel about pre-commit and post-receive hooks?

brooke-hamilton · 2024-11-01T20:56:06Z

Anything that can catch me being forgetful before the push is awesome, along the same lines how do folk feel about pre-commit and post-receive hooks?

@superbeeny thank you for the comment! 🎸 I created issue #8022 to track this. In the issue I described adding shellcheck to the PR validation checks, and I'm thinking that using the VS Code extension + the PR checks is enough, but if you think we should also configure pre- and post-commit checks in git lets continue the discussion.

rynowak · 2024-11-06T16:14:52Z

Anything that can catch me being forgetful before the push is awesome, along the same lines how do folk feel about pre-commit and post-receive hooks?

I'm a fan of pre-commit hooks, but also understand that they optional and a lot of folk will ignore them 😆.

I'm not sure I've seen a post-receive hook in the wild. What do you use them for?

superbeeny · 2024-11-06T16:59:10Z

Anything that can catch me being forgetful before the push is awesome, along the same lines how do folk feel about pre-commit and post-receive hooks?

I'm a fan of pre-commit hooks, but also understand that they optional and a lot of folk will ignore them 😆.

I'm not sure I've seen a post-receive hook in the wild. What do you use them for?

Let them ignore them at their peril! I'd like a hook to run make generate before committing 🤣 I haven't used post-receive in a long time, but would use them for notifications and any other server side nonsense

rynowak · 2024-11-06T17:03:47Z

Let them ignore them at their peril! I'd like a hook to run make generate before committing 🤣 I haven't used post-receive in a long time, but would use them for notifications and any other server side nonsense

If you want to add something, send us a PR 😆 As long as it's optional, that seems like a good experiment to try.

radius-functional-tests · 2024-11-13T22:54:43Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	brooke-hamilton/radius
Commit ref	`8c86fb2`
Unique ID	func25d155d253
Image tag	pr-func25d155d253

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func25d155d253
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func25d155d253
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func25d155d253
controller test image location: ghcr.io/radius-project/dev/controller:pr-func25d155d253
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func25d155d253
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

radius-functional-tests · 2024-11-13T23:45:24Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	brooke-hamilton/radius
Commit ref	`87f85e4`
Unique ID	func961b1df22c
Image tag	pr-func961b1df22c

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func961b1df22c
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func961b1df22c
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func961b1df22c
controller test image location: ghcr.io/radius-project/dev/controller:pr-func961b1df22c
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func961b1df22c
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

brooke-hamilton requested review from a team as code owners September 25, 2024 18:12

rynowak previously approved these changes Sep 25, 2024

View reviewed changes

brooke-hamilton temporarily deployed to functional-tests September 25, 2024 18:19 — with GitHub Actions Inactive

Add shellcheck extension to dev container

7278347

Signed-off-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com>

ytimocin force-pushed the shellcheck branch from 47f09ec to 7278347 Compare September 27, 2024 07:34

ytimocin temporarily deployed to functional-tests September 27, 2024 07:36 — with GitHub Actions Inactive

Merge branch 'main' into shellcheck

f5cb333

Signed-off-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com>

brooke-hamilton dismissed rynowak’s stale review via f5cb333 October 24, 2024 16:46

brooke-hamilton temporarily deployed to functional-tests October 24, 2024 17:12 — with GitHub Actions Inactive

brooke-hamilton mentioned this pull request Nov 1, 2024

Integrate shellcheck into PR checks #8022

Open

1 task

Merge branch 'main' into shellcheck

83a2986

brooke-hamilton temporarily deployed to publish-bicep November 6, 2024 21:27 — with GitHub Actions Inactive

Merge branch 'main' into shellcheck

8c86fb2

brooke-hamilton temporarily deployed to publish-bicep November 13, 2024 22:51 — with GitHub Actions Inactive

brooke-hamilton temporarily deployed to functional-tests November 13, 2024 22:53 — with GitHub Actions Inactive

Merge branch 'main' into shellcheck

87f85e4

brooke-hamilton temporarily deployed to publish-bicep November 13, 2024 23:42 — with GitHub Actions Inactive

brooke-hamilton temporarily deployed to functional-tests November 13, 2024 23:43 — with GitHub Actions Inactive

ytimocin approved these changes Nov 14, 2024

View reviewed changes

ytimocin merged commit 70ff3f8 into radius-project:main Nov 14, 2024
29 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add shellcheck extension to dev container #7963

Add shellcheck extension to dev container #7963

brooke-hamilton commented Sep 25, 2024

radius-functional-tests bot commented Sep 25, 2024 •

edited

Loading

codecov bot commented Sep 25, 2024 •

edited

Loading

radius-functional-tests bot commented Sep 27, 2024 •

edited

Loading

radius-functional-tests bot commented Oct 24, 2024 •

edited

Loading

superbeeny commented Nov 1, 2024

brooke-hamilton commented Nov 1, 2024

rynowak commented Nov 6, 2024

superbeeny commented Nov 6, 2024

rynowak commented Nov 6, 2024

radius-functional-tests bot commented Nov 13, 2024 •

edited

Loading

radius-functional-tests bot commented Nov 13, 2024 •

edited

Loading

Add shellcheck extension to dev container #7963

Add shellcheck extension to dev container #7963

Conversation

brooke-hamilton commented Sep 25, 2024

Description

Type of change

radius-functional-tests bot commented Sep 25, 2024 • edited Loading

Radius functional test overview

Test Status

codecov bot commented Sep 25, 2024 • edited Loading

Codecov Report

radius-functional-tests bot commented Sep 27, 2024 • edited Loading

Radius functional test overview

Test Status

radius-functional-tests bot commented Oct 24, 2024 • edited Loading

Radius functional test overview

Test Status

superbeeny commented Nov 1, 2024

brooke-hamilton commented Nov 1, 2024

rynowak commented Nov 6, 2024

superbeeny commented Nov 6, 2024

rynowak commented Nov 6, 2024

radius-functional-tests bot commented Nov 13, 2024 • edited Loading

Radius functional test overview

Test Status

radius-functional-tests bot commented Nov 13, 2024 • edited Loading

Radius functional test overview

Test Status

radius-functional-tests bot commented Sep 25, 2024 •

edited

Loading

codecov bot commented Sep 25, 2024 •

edited

Loading

radius-functional-tests bot commented Sep 27, 2024 •

edited

Loading

radius-functional-tests bot commented Oct 24, 2024 •

edited

Loading

radius-functional-tests bot commented Nov 13, 2024 •

edited

Loading

radius-functional-tests bot commented Nov 13, 2024 •

edited

Loading