[UDT PR 4 of N] Add basic commands for UDT support #8035

rynowak · 2024-11-06T00:07:19Z

Description

This change adds the most basic commands for interacting with resource providers and resource types. Also added some flexibility to existing commands for resources so they can work with UDTs.

rad resourceprovider
- list
- show
- delete
rad resourcetype
- list
- show

Also added rad resource create. We never implemented anything like this, it was just missing.

Also enhanced the rad resource family of commands to support any fully-qualified resource type. These commands now how to validate and work with the set of built-in types in Radius today using short names like containers.

This set of commands are the easy decisions, and already work well using the existing functionality in the implementation. We'll add some of the more complex commands after a design discussion.

Type of change

This pull request adds or changes features of Radius and has an approved issue (issue link required).

Part of: #6688

Contributor checklist

Please verify that the PR meets the following requirements, where applicable:

An overview of proposed schema changes is included in a linked GitHub issue.
A design document PR is created in the design-notes repository, if new APIs are being introduced.
If applicable, design document has been reviewed and approved by Radius maintainers/approvers.
A PR for the samples repository is created, if existing samples are affected by the changes in this PR.
A PR for the documentation repository is created, if the changes in this PR affect the documentation or any user facing updates are made.
A PR for the recipes repository is created, if existing recipes are affected by the changes in this PR.

rynowak · 2024-11-06T00:07:33Z

/cc @Reshrahim for feedback on command and help text.

codecov · 2024-11-06T00:21:44Z

Codecov Report

Attention: Patch coverage is 71.26100% with 196 lines in your changes missing coverage. Please review.

Project coverage is 59.15%. Comparing base (9e41b41) to head (3840320).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
pkg/cli/clients/management.go	46.09%	46 Missing and 23 partials ⚠️
pkg/cli/cmd/resourceprovider/delete/delete.go	71.25%	15 Missing and 8 partials ⚠️
pkg/cli/cmd/resourcetype/delete/delete.go	72.61%	15 Missing and 8 partials ⚠️
pkg/cli/cmd/resource/create/create.go	77.50%	12 Missing and 6 partials ⚠️
pkg/cli/cmd/resourceprovider/list/list.go	73.68%	10 Missing and 5 partials ⚠️
pkg/cli/cmd/resourceprovider/show/show.go	74.13%	10 Missing and 5 partials ⚠️
pkg/cli/cmd/resourcetype/list/list.go	75.40%	10 Missing and 5 partials ⚠️
pkg/cli/cmd/resourcetype/show/show.go	78.87%	10 Missing and 5 partials ⚠️
pkg/cli/cmd/resource/delete/delete.go	66.66%	2 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8035      +/-   ##
==========================================
+ Coverage   58.94%   59.15%   +0.20%     
==========================================
  Files         567      576       +9     
  Lines       37726    38407     +681     
==========================================
+ Hits        22236    22718     +482     
- Misses      13945    14077     +132     
- Partials     1545     1612      +67

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

radius-functional-tests · 2024-11-06T16:09:16Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	rynowak/radius
Commit ref	`7bb1ca2`
Unique ID	func5f3d438894
Image tag	pr-func5f3d438894

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func5f3d438894
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func5f3d438894
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func5f3d438894
controller test image location: ghcr.io/radius-project/dev/controller:pr-func5f3d438894
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func5f3d438894
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
❌ Failed to install Radius for corerp-cloud functional test. Please check the logs for more details
❌ corerp-cloud functional test failed. Please check the logs for more details
❌ ucp-cloud functional test cancelled. Please check the logs for more details

radius-functional-tests · 2024-11-06T16:59:41Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	rynowak/radius
Commit ref	`0daafcb`
Unique ID	func1208ddf4a3
Image tag	pr-func1208ddf4a3

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func1208ddf4a3
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func1208ddf4a3
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func1208ddf4a3
controller test image location: ghcr.io/radius-project/dev/controller:pr-func1208ddf4a3
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func1208ddf4a3
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

rynowak · 2024-11-06T17:46:17Z

This PR will need a rebase. I'll wait until after getting feedback.

Reshrahim

Suggested some changes.

pkg/cli/cmd/resource/create/create.go

pkg/cli/cmd/resourceprovider/delete/delete.go

pkg/cli/cmd/resourceprovider/list/list.go

pkg/cli/cmd/resourceprovider/show/show.go

Reshrahim · 2024-11-06T16:33:13Z

pkg/cli/cmd/resourcetype/list/list.go

+		Short: "List resource resource types",
+		Long: `List resource resource types
+
+Resource types are the entities that can be created and managed by Radius such as 'Applications.Core/containers'. Resource types can be configured using resource providers.`,


Suggested change

Resource types are the entities that can be created and managed by Radius such as 'Applications.Core/containers'. Resource types can be configured using resource providers.`,

Resource types are schema definitions for resources that can be created and managed by Radius such as 'Applications.Core/containers'. Resource types can be configured using resource providers.`,

They aren't really just the schema defintions. Schema is definitely an important part. Let me try rephrasing...

For example it's not actually the resource types that define a schema. Resource types define api versions, and api versions define schemas.

pkg/cli/cmd/resourcetype/show/show.go

cmd/rad/cmd/resourceprovider.go

cmd/rad/cmd/root.go

pkg/cli/clients/management.go

pkg/cli/clients/clients.go

pkg/cli/clients/management.go

pkg/cli/clients/management_mocks.go

pkg/cli/clivalidation.go

pkg/cli/cmd/resourceprovider/delete/delete.go

pkg/cli/cmd/resourcetype/list/list.go

pkg/cli/cmd/resourcetype/show/show.go

cmd/rad/cmd/root.go

This change adds the most basic commands for interacting with resource providers and resource types. Also added some flexibility to existing commands for resources so they can work with UDTs. - `rad resourceprovider` - `list` - `show` - `delete` - `rad resourcetype` - `list` - `show` Also added `rad resource create`. We never implemented anything like this, it was just missing. Also enhanced the `rad resource` family of commands to support any fully-qualified resource type. These commands now how to validate and work with the set of built-in types in Radius today using short names like `containers`. This set of commands are the easy decisions, and already work well using the existing functionality in the implementation. We'll add some of the more complex commands after a design dicussion. Signed-off-by: Ryan Nowak <nowakra@gmail.com>

rynowak · 2024-11-11T00:33:38Z

@Reshrahim @ytimocin @nithyatsu - updated

radius-functional-tests · 2024-11-11T00:34:10Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	rynowak/radius
Commit ref	`b0a69ea`
Unique ID	func394ed6196b
Image tag	pr-func394ed6196b

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func394ed6196b
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func394ed6196b
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func394ed6196b
controller test image location: ghcr.io/radius-project/dev/controller:pr-func394ed6196b
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func394ed6196b
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

superbeeny

Nice, clean, easy to follow code. Nothing really to add aside from a semantic nit or two, LGTM

pkg/cli/cmd/resource/create/create.go

Signed-off-by: Ryan Nowak <nowakra@gmail.com>

radius-functional-tests · 2024-11-11T21:00:56Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	rynowak/radius
Commit ref	`ef814d7`
Unique ID	func8e480a4e33
Image tag	pr-func8e480a4e33

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func8e480a4e33
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func8e480a4e33
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func8e480a4e33
controller test image location: ghcr.io/radius-project/dev/controller:pr-func8e480a4e33
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func8e480a4e33
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

cmd/rad/cmd/resourceprovider.go

Signed-off-by: Ryan Nowak <nowakra@gmail.com>

cmd/rad/cmd/resourceprovider.go

ytimocin · 2024-11-11T21:43:58Z

pkg/cli/clients/management_mocks.go

+	NewListProviderSummariesPager(planeName string, options *ucpv20231001.ResourceProvidersClientListProviderSummariesOptions) *runtime.Pager[ucpv20231001.ResourceProvidersClientListProviderSummariesResponse]
+}
+
+// resourceProviderClient is an interface for mocking the generated SDK client for resource types.


Suggested change

// resourceProviderClient is an interface for mocking the generated SDK client for resource types.

// resourceTypeClient is an interface for mocking the generated SDK client for resource types.

Thanks for catching this. I'm just about to hit send on another PR that will touch this file, so I'll fix it then if that's OK.

pkg/cli/cmd/resourcetype/list/list.go

radius-functional-tests · 2024-11-11T21:50:37Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	rynowak/radius
Commit ref	`3840320`
Unique ID	funcfd90a707d9
Image tag	pr-funcfd90a707d9

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funcfd90a707d9
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funcfd90a707d9
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-funcfd90a707d9
controller test image location: ghcr.io/radius-project/dev/controller:pr-funcfd90a707d9
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funcfd90a707d9
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

rynowak requested review from a team as code owners November 6, 2024 00:07

rynowak temporarily deployed to publish-bicep November 6, 2024 00:08 — with GitHub Actions Inactive

rynowak force-pushed the udt-basic-commands branch from 5888cd8 to 7bb1ca2 Compare November 6, 2024 16:07

rynowak temporarily deployed to publish-bicep November 6, 2024 16:07 — with GitHub Actions Inactive

rynowak temporarily deployed to functional-tests November 6, 2024 16:08 — with GitHub Actions Inactive

rynowak temporarily deployed to publish-bicep November 6, 2024 16:23 — with GitHub Actions Inactive

rynowak force-pushed the udt-basic-commands branch from 7bb1ca2 to 0daafcb Compare November 6, 2024 16:54

rynowak temporarily deployed to publish-bicep November 6, 2024 16:54 — with GitHub Actions Inactive

rynowak temporarily deployed to functional-tests November 6, 2024 16:58 — with GitHub Actions Inactive

Reshrahim reviewed Nov 6, 2024

View reviewed changes

nithyatsu reviewed Nov 7, 2024

View reviewed changes

cmd/rad/cmd/resourceprovider.go Outdated Show resolved Hide resolved

nithyatsu reviewed Nov 7, 2024

View reviewed changes

cmd/rad/cmd/root.go Show resolved Hide resolved

nithyatsu reviewed Nov 7, 2024

View reviewed changes

pkg/cli/clients/management.go Outdated Show resolved Hide resolved

nithyatsu reviewed Nov 7, 2024

View reviewed changes

pkg/cli/clients/management.go Show resolved Hide resolved

ytimocin reviewed Nov 8, 2024

View reviewed changes

ytimocin force-pushed the udt-basic-commands branch from 0daafcb to 9bcf48c Compare November 8, 2024 04:06

ytimocin temporarily deployed to publish-bicep November 8, 2024 04:06 — with GitHub Actions Inactive

rynowak force-pushed the udt-basic-commands branch from 9bcf48c to b0a69ea Compare November 11, 2024 00:23

rynowak temporarily deployed to publish-bicep November 11, 2024 00:23 — with GitHub Actions Inactive

rynowak temporarily deployed to functional-tests November 11, 2024 00:33 — with GitHub Actions Inactive

rynowak changed the title ~~Add basic commands for UDT support~~ [UDT PR 4 of N] Add basic commands for UDT support Nov 11, 2024

superbeeny reviewed Nov 11, 2024

View reviewed changes

rynowak commented Nov 11, 2024

View reviewed changes

pkg/cli/cmd/resource/create/create.go Outdated Show resolved Hide resolved

Update pkg/cli/cmd/resource/create/create.go

ef814d7

Signed-off-by: Ryan Nowak <nowakra@gmail.com>

rynowak temporarily deployed to publish-bicep November 11, 2024 20:47 — with GitHub Actions Inactive

rynowak temporarily deployed to functional-tests November 11, 2024 21:00 — with GitHub Actions Inactive

rynowak commented Nov 11, 2024

View reviewed changes

cmd/rad/cmd/resourceprovider.go Outdated Show resolved Hide resolved

Update cmd/rad/cmd/resourceprovider.go

3840320

Signed-off-by: Ryan Nowak <nowakra@gmail.com>

rynowak temporarily deployed to publish-bicep November 11, 2024 21:49 — with GitHub Actions Inactive

rynowak temporarily deployed to functional-tests November 11, 2024 21:49 — with GitHub Actions Inactive

ytimocin approved these changes Nov 11, 2024

View reviewed changes

rynowak merged commit 7e4d565 into radius-project:main Nov 12, 2024
29 checks passed

rynowak deleted the udt-basic-commands branch November 12, 2024 00:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[UDT PR 4 of N] Add basic commands for UDT support #8035

[UDT PR 4 of N] Add basic commands for UDT support #8035

rynowak commented Nov 6, 2024

rynowak commented Nov 6, 2024

codecov bot commented Nov 6, 2024 •

edited

Loading

radius-functional-tests bot commented Nov 6, 2024 •

edited

Loading

radius-functional-tests bot commented Nov 6, 2024 •

edited

Loading

rynowak commented Nov 6, 2024

Reshrahim left a comment

Reshrahim Nov 6, 2024

rynowak Nov 10, 2024

rynowak Nov 10, 2024

rynowak commented Nov 11, 2024

radius-functional-tests bot commented Nov 11, 2024 •

edited

Loading

superbeeny left a comment

radius-functional-tests bot commented Nov 11, 2024 •

edited

Loading

ytimocin Nov 11, 2024

rynowak Nov 12, 2024

radius-functional-tests bot commented Nov 11, 2024 •

edited

Loading

	Resource types are the entities that can be created and managed by Radius such as 'Applications.Core/containers'. Resource types can be configured using resource providers.`,
	Resource types are schema definitions for resources that can be created and managed by Radius such as 'Applications.Core/containers'. Resource types can be configured using resource providers.`,

	// resourceProviderClient is an interface for mocking the generated SDK client for resource types.
	// resourceTypeClient is an interface for mocking the generated SDK client for resource types.

[UDT PR 4 of N] Add basic commands for UDT support #8035

[UDT PR 4 of N] Add basic commands for UDT support #8035

Conversation

rynowak commented Nov 6, 2024

Description

Type of change

Contributor checklist

rynowak commented Nov 6, 2024

codecov bot commented Nov 6, 2024 • edited Loading

Codecov Report

radius-functional-tests bot commented Nov 6, 2024 • edited Loading

Radius functional test overview

Test Status

radius-functional-tests bot commented Nov 6, 2024 • edited Loading

Radius functional test overview

Test Status

rynowak commented Nov 6, 2024

Reshrahim left a comment

Choose a reason for hiding this comment

Reshrahim Nov 6, 2024

Choose a reason for hiding this comment

rynowak Nov 10, 2024

Choose a reason for hiding this comment

rynowak Nov 10, 2024

Choose a reason for hiding this comment

rynowak commented Nov 11, 2024

radius-functional-tests bot commented Nov 11, 2024 • edited Loading

Radius functional test overview

Test Status

superbeeny left a comment

Choose a reason for hiding this comment

radius-functional-tests bot commented Nov 11, 2024 • edited Loading

Radius functional test overview

Test Status

ytimocin Nov 11, 2024

Choose a reason for hiding this comment

rynowak Nov 12, 2024

Choose a reason for hiding this comment

radius-functional-tests bot commented Nov 11, 2024 • edited Loading

Radius functional test overview

Test Status

codecov bot commented Nov 6, 2024 •

edited

Loading

radius-functional-tests bot commented Nov 6, 2024 •

edited

Loading

radius-functional-tests bot commented Nov 6, 2024 •

edited

Loading

radius-functional-tests bot commented Nov 11, 2024 •

edited

Loading

radius-functional-tests bot commented Nov 11, 2024 •

edited

Loading

radius-functional-tests bot commented Nov 11, 2024 •

edited

Loading