Reformat args for radius installation #8038

rynowak · 2024-11-06T18:45:49Z

Description

This change reformats the args passed into to "install radius" in the cloud functional tests. This was a single line before and really hard to review or change.

This broke in one of my recent changes.

Type of change

This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

Contributor checklist

Please verify that the PR meets the following requirements, where applicable:

An overview of proposed schema changes is included in a linked GitHub issue.
A design document PR is created in the design-notes repository, if new APIs are being introduced.
If applicable, design document has been reviewed and approved by Radius maintainers/approvers.
A PR for the samples repository is created, if existing samples are affected by the changes in this PR.
A PR for the documentation repository is created, if the changes in this PR affect the documentation or any user facing updates are made.
A PR for the recipes repository is created, if existing recipes are affected by the changes in this PR.

rynowak · 2024-11-06T18:47:29Z

.github/workflows/functional-test-cloud.yaml

+            --set controller.image=${{ env.CONTAINER_REGISTRY }}/controller,controller.tag=${{ env.REL_VERSION }} \
+            --set ucp.image=${{ env.CONTAINER_REGISTRY }}/ucpd,ucp.tag=${{ env.REL_VERSION }} \
+            --set de.image=${{ env.DE_IMAGE }},de.tag=${{ env.DE_TAG }} \
+            --set global.azureWorkloadIdentity.enabled=true


Compare with: https://github.com/radius-project/radius/blob/main/.github/workflows/functional-test-noncloud.yaml#L290

radius-functional-tests · 2024-11-06T18:47:35Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	rynowak/radius
Commit ref	`d85ebc5`
Unique ID	funca64b665df4
Image tag	pr-funca64b665df4

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funca64b665df4
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funca64b665df4
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-funca64b665df4
controller test image location: ghcr.io/radius-project/dev/controller:pr-funca64b665df4
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funca64b665df4
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

ytimocin

What changed here other than the lines? :D

rynowak · 2024-11-06T18:48:01Z

What changed here other than the lines? :D

Just the lines.

codecov · 2024-11-06T18:57:18Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.08%. Comparing base (a3014bd) to head (1fe69ab).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8038      +/-   ##
==========================================
- Coverage   59.09%   59.08%   -0.01%     
==========================================
  Files         567      567              
  Lines       37726    37726              
==========================================
- Hits        22293    22290       -3     
- Misses      13885    13887       +2     
- Partials     1548     1549       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rynowak · 2024-11-06T22:43:58Z

As discussed, I'll hold off on this change until after the release. I'm in no rush to break the build again.

Signed-off-by: Ryan Nowak <nowakra@gmail.com>

radius-functional-tests · 2024-11-08T01:33:10Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	rynowak/radius
Commit ref	`1fe69ab`
Unique ID	func61d440b667
Image tag	pr-func61d440b667

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func61d440b667
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func61d440b667
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func61d440b667
controller test image location: ghcr.io/radius-project/dev/controller:pr-func61d440b667
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func61d440b667
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

rynowak · 2024-11-10T21:44:34Z

Hey everyone, I'm going to merge this and hope that it works. I'll babysit the build in case this breaks something.

radius-functional-tests · 2024-11-10T21:47:14Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	rynowak/radius
Commit ref	`2becf61`
Unique ID	funcd700f1f348
Image tag	pr-funcd700f1f348

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funcd700f1f348
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funcd700f1f348
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-funcd700f1f348
controller test image location: ghcr.io/radius-project/dev/controller:pr-funcd700f1f348
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funcd700f1f348
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

rynowak requested review from a team as code owners November 6, 2024 18:45

rynowak temporarily deployed to publish-bicep November 6, 2024 18:46 — with GitHub Actions Inactive

rynowak temporarily deployed to functional-tests November 6, 2024 18:46 — with GitHub Actions Inactive

rynowak commented Nov 6, 2024

View reviewed changes

ytimocin approved these changes Nov 6, 2024

View reviewed changes

willdavsmith approved these changes Nov 6, 2024

View reviewed changes

kachawla approved these changes Nov 6, 2024

View reviewed changes

Reformat args for radius installation

1fe69ab

Signed-off-by: Ryan Nowak <nowakra@gmail.com>

ytimocin force-pushed the functional-test-fun branch from d85ebc5 to 1fe69ab Compare November 8, 2024 01:31

ytimocin temporarily deployed to publish-bicep November 8, 2024 01:32 — with GitHub Actions Inactive

ytimocin temporarily deployed to functional-tests November 8, 2024 01:32 — with GitHub Actions Inactive

Merge branch 'main' into functional-test-fun

2becf61

rynowak temporarily deployed to publish-bicep November 10, 2024 21:44 — with GitHub Actions Inactive

rynowak temporarily deployed to functional-tests November 10, 2024 21:46 — with GitHub Actions Inactive

rynowak merged commit ac082c2 into radius-project:main Nov 10, 2024
27 of 28 checks passed

rynowak deleted the functional-test-fun branch November 10, 2024 22:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reformat args for radius installation #8038

Reformat args for radius installation #8038

rynowak commented Nov 6, 2024

rynowak Nov 6, 2024

radius-functional-tests bot commented Nov 6, 2024 •

edited

Loading

ytimocin left a comment

rynowak commented Nov 6, 2024

codecov bot commented Nov 6, 2024 •

edited

Loading

rynowak commented Nov 6, 2024

radius-functional-tests bot commented Nov 8, 2024 •

edited

Loading

rynowak commented Nov 10, 2024

radius-functional-tests bot commented Nov 10, 2024 •

edited

Loading

Reformat args for radius installation #8038

Reformat args for radius installation #8038

Conversation

rynowak commented Nov 6, 2024

Description

Type of change

Contributor checklist

rynowak Nov 6, 2024

Choose a reason for hiding this comment

radius-functional-tests bot commented Nov 6, 2024 • edited Loading

Radius functional test overview

Test Status

ytimocin left a comment

Choose a reason for hiding this comment

rynowak commented Nov 6, 2024

codecov bot commented Nov 6, 2024 • edited Loading

Codecov Report

rynowak commented Nov 6, 2024

radius-functional-tests bot commented Nov 8, 2024 • edited Loading

Radius functional test overview

Test Status

rynowak commented Nov 10, 2024

radius-functional-tests bot commented Nov 10, 2024 • edited Loading

Radius functional test overview

Test Status

radius-functional-tests bot commented Nov 6, 2024 •

edited

Loading

codecov bot commented Nov 6, 2024 •

edited

Loading

radius-functional-tests bot commented Nov 8, 2024 •

edited

Loading

radius-functional-tests bot commented Nov 10, 2024 •

edited

Loading