Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version for dependency to use tilde instead of carat #8041

Merged

Conversation

lakshmimsft
Copy link
Contributor

@lakshmimsft lakshmimsft commented Nov 8, 2024

Description

Update version for dependency @azure-tools/typespec-providerhub to use tilde instead of carat

  • This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

Fixes: #issue_number

Contributor checklist

Please verify that the PR meets the following requirements, where applicable:

  • An overview of proposed schema changes is included in a linked GitHub issue.
  • A design document PR is created in the design-notes repository, if new APIs are being introduced.
  • If applicable, design document has been reviewed and approved by Radius maintainers/approvers.
  • A PR for the samples repository is created, if existing samples are affected by the changes in this PR.
  • A PR for the documentation repository is created, if the changes in this PR affect the documentation or any user facing updates are made.
  • A PR for the recipes repository is created, if existing recipes are affected by the changes in this PR.

@radius-functional-tests
Copy link

radius-functional-tests bot commented Nov 8, 2024

Radius functional test overview

🔍 Go to test action run

Name Value
Repository lakshmimsft/radius-mainfork
Commit ref b99fee8
Unique ID func8b63b2c57a
Image tag pr-func8b63b2c57a
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr: 1.12.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func8b63b2c57a
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func8b63b2c57a
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func8b63b2c57a
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func8b63b2c57a
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func8b63b2c57a
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

@@ -7,7 +7,7 @@
"@azure-tools/typespec-autorest": "~0.46.0",
"@azure-tools/typespec-azure-core": "~0.46.0",
"@azure-tools/typespec-azure-resource-manager": "~0.46.0",
"@azure-tools/typespec-providerhub": "^0.47.0",
Copy link
Contributor

@rynowak rynowak Nov 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be ~0.46.0? I think it would be best to use all 0.46.x versions instead of one of them randomly being 0.47.x.

You should also run npm ci in this directory to update package-lock.json

This reverts commit 222be6b.
@radius-functional-tests
Copy link

radius-functional-tests bot commented Nov 8, 2024

Radius functional test overview

🔍 Go to test action run

Name Value
Repository lakshmimsft/radius-mainfork
Commit ref 21b1c2e
Unique ID funcb226f2b975
Image tag pr-funcb226f2b975
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr: 1.12.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funcb226f2b975
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funcb226f2b975
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-funcb226f2b975
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-funcb226f2b975
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funcb226f2b975
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

Copy link
Contributor

@rynowak rynowak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this 👍

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.08%. Comparing base (a3014bd) to head (21b1c2e).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8041      +/-   ##
==========================================
- Coverage   59.09%   59.08%   -0.01%     
==========================================
  Files         567      567              
  Lines       37726    37726              
==========================================
- Hits        22293    22290       -3     
- Misses      13885    13887       +2     
- Partials     1548     1549       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lakshmimsft lakshmimsft merged commit f5604d0 into radius-project:main Nov 8, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants