-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update version for dependency to use tilde instead of carat #8041
Update version for dependency to use tilde instead of carat #8041
Conversation
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
@@ -7,7 +7,7 @@ | |||
"@azure-tools/typespec-autorest": "~0.46.0", | |||
"@azure-tools/typespec-azure-core": "~0.46.0", | |||
"@azure-tools/typespec-azure-resource-manager": "~0.46.0", | |||
"@azure-tools/typespec-providerhub": "^0.47.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be ~0.46.0
? I think it would be best to use all 0.46.x
versions instead of one of them randomly being 0.47.x
.
You should also run npm ci
in this directory to update package-lock.json
b99fee8
to
222be6b
Compare
This reverts commit 222be6b.
179a319
to
21b1c2e
Compare
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this 👍
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8041 +/- ##
==========================================
- Coverage 59.09% 59.08% -0.01%
==========================================
Files 567 567
Lines 37726 37726
==========================================
- Hits 22293 22290 -3
- Misses 13885 13887 +2
- Partials 1548 1549 +1 ☔ View full report in Codecov by Sentry. |
Description
Update version for dependency @azure-tools/typespec-providerhub to use tilde instead of carat
Fixes: #issue_number
Contributor checklist
Please verify that the PR meets the following requirements, where applicable: