Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skipping flaky test #8045

Merged
merged 1 commit into from
Nov 10, 2024
Merged

Skipping flaky test #8045

merged 1 commit into from
Nov 10, 2024

Conversation

rynowak
Copy link
Contributor

@rynowak rynowak commented Nov 10, 2024

Description

Skipping flaky test

Type of change

  • This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

Contributor checklist

Please verify that the PR meets the following requirements, where applicable:

  • An overview of proposed schema changes is included in a linked GitHub issue.
  • A design document PR is created in the design-notes repository, if new APIs are being introduced.
  • If applicable, design document has been reviewed and approved by Radius maintainers/approvers.
  • A PR for the samples repository is created, if existing samples are affected by the changes in this PR.
  • A PR for the documentation repository is created, if the changes in this PR affect the documentation or any user facing updates are made.
  • A PR for the recipes repository is created, if existing recipes are affected by the changes in this PR.

Signed-off-by: Ryan Nowak <nowakra@gmail.com>
@rynowak rynowak requested review from a team as code owners November 10, 2024 22:18
@rynowak rynowak merged commit 9e41b41 into radius-project:main Nov 10, 2024
17 of 19 checks passed
@rynowak rynowak deleted the flaky-test branch November 10, 2024 22:18
@rynowak
Copy link
Contributor Author

rynowak commented Nov 10, 2024

FYI only - this test is flaky and needs to be disabled.

Copy link

codecov bot commented Nov 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.92%. Comparing base (ac082c2) to head (05ba1ce).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8045      +/-   ##
==========================================
- Coverage   59.08%   58.92%   -0.16%     
==========================================
  Files         567      567              
  Lines       37726    37726              
==========================================
- Hits        22290    22230      -60     
- Misses      13887    13949      +62     
+ Partials     1549     1547       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant