Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor spelling update delete.go #8059

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Conversation

Reshrahim
Copy link
Contributor

Description

spelling fix

Type of change

  • This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

Fixes: #issue_number

Contributor checklist

Please verify that the PR meets the following requirements, where applicable:

  • An overview of proposed schema changes is included in a linked GitHub issue.
  • A design document PR is created in the design-notes repository, if new APIs are being introduced.
  • If applicable, design document has been reviewed and approved by Radius maintainers/approvers.
  • A PR for the samples repository is created, if existing samples are affected by the changes in this PR.
  • A PR for the documentation repository is created, if the changes in this PR affect the documentation or any user facing updates are made.
  • A PR for the recipes repository is created, if existing recipes are affected by the changes in this PR.

Signed-off-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com>
@Reshrahim Reshrahim requested review from a team as code owners November 14, 2024 22:03
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.20%. Comparing base (d602015) to head (12c1376).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8059      +/-   ##
==========================================
- Coverage   59.21%   59.20%   -0.01%     
==========================================
  Files         579      579              
  Lines       38697    38697              
==========================================
- Hits        22914    22911       -3     
- Misses      14145    14147       +2     
- Partials     1638     1639       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@radius-functional-tests
Copy link

radius-functional-tests bot commented Nov 14, 2024

Radius functional test overview

🔍 Go to test action run

Name Value
Repository Reshrahim/radius
Commit ref 12c1376
Unique ID func4b58f17955
Image tag pr-func4b58f17955
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr: 1.12.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func4b58f17955
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func4b58f17955
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func4b58f17955
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func4b58f17955
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func4b58f17955
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

@lakshmimsft lakshmimsft merged commit 3028400 into radius-project:main Nov 14, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants