Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing #8043 - adding long form commands and aliasing abbreviations #8073

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

superbeeny
Copy link
Contributor

Description

Updated cmd line functions to use environment in place of env and initialize in place of init. Both abbreviations are now aliased so this is a non breaking change.

Type of change

  • This pull request fixes a bug in Radius and has an approved issue (issue link required).

Fixes: #8043

Contributor checklist

Please verify that the PR meets the following requirements, where applicable:

  • An overview of proposed schema changes is included in a linked GitHub issue.
  • A design document PR is created in the design-notes repository, if new APIs are being introduced.
  • If applicable, design document has been reviewed and approved by Radius maintainers/approvers.
  • A PR for the samples repository is created, if existing samples are affected by the changes in this PR.
  • A PR for the documentation repository is created, if the changes in this PR affect the documentation or any user facing updates are made.
  • A PR for the recipes repository is created, if existing recipes are affected by the changes in this PR.

…bbreviations

Signed-off-by: Nick Beenham <Nicholas_Beenham@cable.comcast.com>
@radius-functional-tests
Copy link

radius-functional-tests bot commented Nov 20, 2024

Radius functional test overview

🔍 Go to test action run

Name Value
Repository superbeeny/radius
Commit ref 7f2ee9f
Unique ID func2c6dbba861
Image tag pr-func2c6dbba861
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr: 1.12.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func2c6dbba861
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func2c6dbba861
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func2c6dbba861
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func2c6dbba861
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func2c6dbba861
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

Copy link
Contributor

@kachawla kachawla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to ask if we should update examples like this one

, but we haven't done that for rad app examples either, so it likely is fine as is at this point.

@kachawla kachawla merged commit 728f64e into radius-project:main Nov 20, 2024
28 checks passed
@kachawla
Copy link
Contributor

kachawla commented Nov 21, 2024

@superbeeny, looks like some of the docs references would need to be manually updated https://github.com/radius-project/docs/actions/runs/11942519605/job/33289744491?pr=1289.

@Reshrahim, how do you recommend resolving this given the circular dependency between this pr radius-project/docs#1289 and the manual updates needed?

@Reshrahim
Copy link
Contributor

@superbeeny, looks like some of the docs references would need to be manually updated https://github.com/radius-project/docs/actions/runs/11942519605/job/33289744491?pr=1289.

@Reshrahim, how do you recommend resolving this given the circular dependency between this pr radius-project/docs#1289 and the manual updates needed?

yes just noticed the same thing. Easy way is to update the references in the same PR -radius-project/docs#1289

superbeeny added a commit to superbeeny/radius that referenced this pull request Nov 21, 2024
…bbreviations (radius-project#8073)

# Description

Updated cmd line functions to use `environment` in place of `env` and
`initialize` in place of `init`. Both abbreviations are now aliased so
this is a non breaking change.

## Type of change

- This pull request fixes a bug in Radius and has an approved issue
(issue link required).

Fixes: radius-project#8043 

Signed-off-by: Nick Beenham <Nicholas_Beenham@cable.comcast.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rad env should be renamed to rad environment
5 participants