UDT rad resource provider command should support json #8075

nithyatsu · 2024-11-21T22:38:21Z

Description

yaml parser we use automatically supports parsing json, yaml being superset of json.

Updated texts and test to capture a valid json input and a validation error for json input.

Type of change

This pull request adds or changes features of Radius and has an approved issue (issue link required).
This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

Fixes: https://dev.azure.com/azure-octo/Incubations/_workitems/edit/13650

Contributor checklist

Please verify that the PR meets the following requirements, where applicable:

An overview of proposed schema changes is included in a linked GitHub issue.
A design document PR is created in the design-notes repository, if new APIs are being introduced.
If applicable, design document has been reviewed and approved by Radius maintainers/approvers.
A PR for the samples repository is created, if existing samples are affected by the changes in this PR.
A PR for the documentation repository is created, if the changes in this PR affect the documentation or any user facing updates are made.
A PR for the recipes repository is created, if existing recipes are affected by the changes in this PR.

radius-functional-tests · 2024-11-21T23:24:55Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	nithyatsu/radius
Commit ref	`3b8ffe3`
Unique ID	func414aefddbd
Image tag	pr-func414aefddbd

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr:
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func414aefddbd
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func414aefddbd
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func414aefddbd
controller test image location: ghcr.io/radius-project/dev/controller:pr-func414aefddbd
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func414aefddbd
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

pkg/cli/cmd/resourceprovider/create/create.go

rynowak

Code changes look good, some feedback on the help text.

radius-functional-tests · 2024-11-25T20:07:35Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	nithyatsu/radius
Commit ref	`eb17c04`
Unique ID	funcf4617b35de
Image tag	pr-funcf4617b35de

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr:
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funcf4617b35de
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funcf4617b35de
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-funcf4617b35de
controller test image location: ghcr.io/radius-project/dev/controller:pr-funcf4617b35de
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funcf4617b35de
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

radius-functional-tests · 2024-11-25T20:43:29Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	nithyatsu/radius
Commit ref	`d5a90fe`
Unique ID	funcfff8d12eaf
Image tag	pr-funcfff8d12eaf

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr:
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funcfff8d12eaf
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funcfff8d12eaf
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-funcfff8d12eaf
controller test image location: ghcr.io/radius-project/dev/controller:pr-funcfff8d12eaf
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funcfff8d12eaf
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

rynowak

radius-functional-tests · 2024-11-25T21:18:46Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	nithyatsu/radius
Commit ref	`ba5f3dc`
Unique ID	func818af3b348
Image tag	pr-func818af3b348

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr:
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func818af3b348
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func818af3b348
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func818af3b348
controller test image location: ghcr.io/radius-project/dev/controller:pr-func818af3b348
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func818af3b348
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

nithyatsu requested review from a team as code owners November 21, 2024 22:38

nithyatsu temporarily deployed to publish-bicep November 21, 2024 22:38 — with GitHub Actions Inactive

nithyatsu temporarily deployed to functional-tests November 21, 2024 23:23 — with GitHub Actions Inactive

nithyatsu changed the title ~~update for json support~~ UDT update for json support Nov 21, 2024

rynowak reviewed Nov 25, 2024

View reviewed changes

pkg/cli/cmd/resourceprovider/create/create.go Outdated Show resolved Hide resolved

rynowak reviewed Nov 25, 2024

View reviewed changes

pkg/cli/cmd/resourceprovider/create/create.go Show resolved Hide resolved

rynowak reviewed Nov 25, 2024

View reviewed changes

nithyatsu temporarily deployed to publish-bicep November 25, 2024 20:02 — with GitHub Actions Inactive

rynowak previously approved these changes Nov 25, 2024

View reviewed changes

nithyatsu dismissed rynowak’s stale review via 9d63da6 November 25, 2024 20:04

nithyatsu had a problem deploying to publish-bicep November 25, 2024 20:04 — with GitHub Actions Error

nithyatsu force-pushed the addJsonSupport branch from 9d63da6 to eb17c04 Compare November 25, 2024 20:05

nithyatsu requested a review from rynowak November 25, 2024 20:06

nithyatsu temporarily deployed to publish-bicep November 25, 2024 20:06 — with GitHub Actions Inactive

nithyatsu temporarily deployed to functional-tests November 25, 2024 20:06 — with GitHub Actions Inactive

nithyatsu temporarily deployed to publish-bicep November 25, 2024 20:41 — with GitHub Actions Inactive

nithyatsu temporarily deployed to functional-tests November 25, 2024 20:42 — with GitHub Actions Inactive

nithyatsu added 4 commits November 25, 2024 13:11

update for json support

f5fe184

wip

bda19e0

wip

2c71585

wip

ba5f3dc

nithyatsu force-pushed the addJsonSupport branch from d5a90fe to ba5f3dc Compare November 25, 2024 21:11

nithyatsu temporarily deployed to publish-bicep November 25, 2024 21:11 — with GitHub Actions Inactive

rynowak approved these changes Nov 25, 2024

View reviewed changes

nithyatsu temporarily deployed to functional-tests November 25, 2024 21:17 — with GitHub Actions Inactive

nithyatsu merged commit fdb5062 into radius-project:main Nov 25, 2024
28 checks passed

nithyatsu changed the title ~~UDT update for json support~~ UDT rad resource command should support json Jan 7, 2025

nithyatsu changed the title ~~UDT rad resource command should support json~~ UDT rad resource provider command should support json Jan 16, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

UDT rad resource provider command should support json #8075

UDT rad resource provider command should support json #8075

nithyatsu commented Nov 21, 2024

radius-functional-tests bot commented Nov 21, 2024 •

edited

Loading

rynowak left a comment

radius-functional-tests bot commented Nov 25, 2024 •

edited

Loading

radius-functional-tests bot commented Nov 25, 2024 •

edited

Loading

rynowak left a comment

radius-functional-tests bot commented Nov 25, 2024 •

edited

Loading

UDT rad resource provider command should support json #8075

UDT rad resource provider command should support json #8075

Conversation

nithyatsu commented Nov 21, 2024

Description

Type of change

Contributor checklist

radius-functional-tests bot commented Nov 21, 2024 • edited Loading

Radius functional test overview

Test Status

rynowak left a comment

Choose a reason for hiding this comment

radius-functional-tests bot commented Nov 25, 2024 • edited Loading

Radius functional test overview

Test Status

radius-functional-tests bot commented Nov 25, 2024 • edited Loading

Radius functional test overview

Test Status

rynowak left a comment

Choose a reason for hiding this comment

radius-functional-tests bot commented Nov 25, 2024 • edited Loading

Radius functional test overview

Test Status

radius-functional-tests bot commented Nov 21, 2024 •

edited

Loading

radius-functional-tests bot commented Nov 25, 2024 •

edited

Loading

radius-functional-tests bot commented Nov 25, 2024 •

edited

Loading

radius-functional-tests bot commented Nov 25, 2024 •

edited

Loading