Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CODEOWNERS #8076

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Update CODEOWNERS #8076

merged 2 commits into from
Nov 26, 2024

Conversation

kachawla
Copy link
Contributor

Description

Combining two codeowners files into one, with root level pointing to the file under the .github directory. More context in #8074.

Type of change

  • This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

Fixes: #8074

Contributor checklist

Please verify that the PR meets the following requirements, where applicable:

  • An overview of proposed schema changes is included in a linked GitHub issue. -- N/A
  • A design document PR is created in the design-notes repository, if new APIs are being introduced. -- N/A
  • If applicable, design document has been reviewed and approved by Radius maintainers/approvers. -- N/A
  • A PR for the samples repository is created, if existing samples are affected by the changes in this PR. -- N/A
  • A PR for the documentation repository is created, if the changes in this PR affect the documentation or any user facing updates are made. -- N/A
  • A PR for the recipes repository is created, if existing recipes are affected by the changes in this PR. -- N/A

@kachawla kachawla requested review from a team as code owners November 21, 2024 23:25
@kachawla kachawla requested a review from willtsai November 21, 2024 23:25
Signed-off-by: karishma-chawla <74574173+karishma-chawla@users.noreply.github.com>
@radius-functional-tests
Copy link

radius-functional-tests bot commented Nov 22, 2024

Radius functional test overview

🔍 Go to test action run

Name Value
Repository kachawla/radius
Commit ref 7e4d313
Unique ID func59b90fa179
Image tag pr-func59b90fa179
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr:
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func59b90fa179
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func59b90fa179
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func59b90fa179
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func59b90fa179
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func59b90fa179
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

Copy link
Contributor

@rynowak rynowak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know if you want me to bypass CI for this change.

@kachawla
Copy link
Contributor Author

Let me know if you want me to bypass CI for this change.

That would be great! Thanks :)

@radius-functional-tests
Copy link

radius-functional-tests bot commented Nov 26, 2024

Radius functional test overview

🔍 Go to test action run

Name Value
Repository kachawla/radius
Commit ref b741e80
Unique ID funccfcf521c7f
Image tag pr-funccfcf521c7f
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr:
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funccfcf521c7f
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funccfcf521c7f
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-funccfcf521c7f
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-funccfcf521c7f
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funccfcf521c7f
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

@kachawla kachawla merged commit ae7c52a into radius-project:main Nov 26, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix inconsistency in CODEOWNERS files
3 participants